Skip to content

Cached config throws error #19

Description

@mbardelmeijer

Using this package with a cached config (php artisan config:cache) & using the default config from the package throws the following error:

Argument 1 passed to Mtownsend\ReadTime\ReadTime::omitSeconds() must be of the type bool, null given, called in vendor/mtownsend/read-time/src/Providers/ReadTimeServiceProvider.php on line 54

I think this is due to the config being loaded in the binding. I think the mergeConfigFrom should be in the boot method of the service provider.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions