Feature: Add --override flag for plugin installation to force re-install/update

[mrgb7]

Feature Request

Summary

Add an --override flag to the playground cluster plugin add command that allows forcing re-installation or updating of plugins even when they are already installed.

Motivation

Currently, when a plugin is already installed, the system prevents re-installation. There are scenarios where users need to:

• Update plugin configuration with new values
• Force a fresh installation with different settings
• Recover from corrupted plugin installations

Proposed Solution

Command Syntax

playground cluster plugin add -n <plugin-name> --override --set <key=value> --cluster <cluster-name>

Example Usage

playground cluster plugin add -n argocd --override --set admin.password=xyz --cluster playground

Implementation Requirements

1. Override Validation:

   • Validate that the --override flag is supported by the target plugin
   • Each plugin should implement an interface method to indicate override support

2. Re-installation Logic:

   • When --override is specified, uninstall the existing plugin first
   • Then proceed with fresh installation using new configuration values

3. Safety Checks:

   • Warn users about potential data loss during re-installation
   • Provide confirmation prompt unless --force is also specified

4. Plugin Interface Extension:

   • Add a method like SupportsOverride() bool to the plugin interface
   • Update existing plugins to implement this method

Acceptance Criteria

• --override flag is recognized by the CLI
• Plugin interface includes override support validation
• ArgoCD plugin supports override functionality
• Proper error handling when override is not supported
• User confirmation prompts for destructive operations
• Integration tests covering override scenarios
• Documentation updated with new flag usage

Related Files

• internal/plugins/argocd.go - Example plugin that should support override
• CLI command handlers for plugin installation

Additional Context

This feature will improve the developer experience by allowing easy plugin reconfiguration and recovery from installation issues.

[mrgb7]

Additional Requirements

Enhanced --set Support

The --override functionality should support multiple --set flags for comprehensive configuration:

playground cluster plugin add -n argocd --override \
  --set admin.password=xyz \
  --set server.replicas=3 \
  --set redis.enabled=true \
  --cluster playground

Installer Type Awareness

The override behavior should be installer-aware and handle different installation methods appropriately:

1. Helm-based Plugins

• Standard uninstall → reinstall flow
• Use helm upgrade --install with new values
• Preserve existing PVCs when possible

2. ArgoCD Application-based Plugins

• Update the ArgoCD Application instead of reinstalling
• Modify the Application's spec with new values
• Trigger application sync/refresh
• Maintain GitOps workflow compatibility

Implementation Details

Installer Detection Logic

type InstallerType string

const (
    InstallerHelm   InstallerType = "helm"
    InstallerArgoCD InstallerType = "argocd"
)

type Plugin interface {
    GetInstallerType() InstallerType
    SupportsOverride() bool
    // ... existing methods
}

Override Flow by Installer Type

Helm Installer:

1. Validate current installation
2. Merge existing values with new --set parameters
3. Execute helm upgrade --install with merged values
4. Verify successful deployment

ArgoCD Installer:

1. Locate the ArgoCD Application resource
2. Update Application spec with new parameters
3. Trigger application sync
4. Monitor sync status and health

Enhanced Command Examples

# Helm-based plugin override
playground cluster plugin add -n prometheus --override \
  --set alertmanager.enabled=true \
  --set grafana.adminPassword=newpass \
  --cluster production

# ArgoCD-based plugin override
playground cluster plugin add -n app-of-apps --override \
  --set source.targetRevision=v2.0.0 \
  --set destination.namespace=production \
  --cluster production

Additional Acceptance Criteria

• Support multiple --set flags in single command
• Detect installer type (Helm vs ArgoCD) automatically
• Helm plugins use upgrade flow instead of uninstall/reinstall
• ArgoCD plugins update Application resources directly
• Preserve data/state during Helm upgrades when possible
• Maintain GitOps compliance for ArgoCD-managed resources
• Error handling for conflicting parameter values
• Validation of parameter syntax and types