Currently, we have an envvars.sample that is supposed to be a template for any required / important envvars that docker environment needs to run.
As of now, this is mainly empty, project is super simple rn but if we ever wanted to pull out envvars from Travis CI and pipe into build, this would be the way to do it.
The main issue is, docker requires envvars file, not envvars.sample, the sample extension exists mainly to discourage accidental pushes of sensitive secrets to scm. This should not be a problem when using make and npm-scripts targets for various processes, but it may become an issue if one wants to run docker compose cmds directly /do something custom.
The ALTERNATIVE would be to simple commit envvars to SCM and tack on a bid ol' warning on top of file to NOT commit sensitive material.
Whatdoyathink? I can go both ways.
@mmosayed? Anyone else? (@crymall already looked at this, wanted to defer to community at large).
Currently, we have an
envvars.samplethat is supposed to be a template for any required / important envvars that docker environment needs to run.As of now, this is mainly empty, project is super simple rn but if we ever wanted to pull out envvars from Travis CI and pipe into build, this would be the way to do it.
The main issue is, docker requires
envvarsfile, notenvvars.sample, the sample extension exists mainly to discourage accidental pushes of sensitive secrets to scm. This should not be a problem when using make and npm-scripts targets for various processes, but it may become an issue if one wants to run docker compose cmds directly /do something custom.The ALTERNATIVE would be to simple commit envvars to SCM and tack on a bid ol' warning on top of file to NOT commit sensitive material.
Whatdoyathink? I can go both ways.
@mmosayed? Anyone else? (@crymall already looked at this, wanted to defer to community at large).