SlicingIterator preserves keys: should it?

[morrisonlevi]

My expectation on a slice is that the keys would be renumbered, since slicing something that doesn't really have an order is sort-of undefined. There needs to be some expectations clearly outlined on this somewhere, and I'm not sure what they should be.

[morrisonlevi]

Note that slice($start, $count) could be be implemented as:

function slice($start, $count) {
    return $this->skip($start)->limit($count);
}

Maybe that will help make semantic sense of everything, I'm not sure.

[morrisonlevi]

Whenever I have realizations like this I always want to implement it immediately. Implementing it as above could eliminate a class. It's a bit off topic for this issue, but I'll think about it.

[morrisonlevi]

I've decided that algorithms should preserve keys by default. Once keys are stripped one cannot magically get them back, but generally one easily re-assign the keys if desired. This ticket will remain open until I've fixed things to retain keys by default.

[hakre]

This here probably is fixed? Also I wouldn't keep it open until the rest is fixed, but just state your decision and close it if implemented.

[morrisonlevi]

I am thinking that this repository will narrow its scope to remove methods like map, filter, etc on classes. This in turn obviates the need for these iterators. Will keep thinking about this.