Commit c8a3035
committed
MAINT: use explicit isinstance(DipoleFixed) check in _line_figure
Replace the try/except AttributeError in _line_figure with an
explicit isinstance(inst, DipoleFixed) check, per review feedback.
DipoleFixed.plot() routes through _plot_evoked/_line_figure but has
no get_channel_types() of its own (no ContainsMixin), only .info, so
it needs the info-based lookup; every other caller (Evoked) has
get_channel_types() directly. The bare try/except masked this and
broke CI when the fallback was removed.1 parent 66b2498 commit c8a3035
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2585 | 2585 | | |
2586 | 2586 | | |
2587 | 2587 | | |
| 2588 | + | |
| 2589 | + | |
2588 | 2590 | | |
2589 | 2591 | | |
2590 | 2592 | | |
2591 | | - | |
| 2593 | + | |
| 2594 | + | |
| 2595 | + | |
| 2596 | + | |
| 2597 | + | |
2592 | 2598 | | |
2593 | 2599 | | |
2594 | 2600 | | |
| |||
0 commit comments