From 5a9de97b737ac63436ca54a151673e21b3de2a77 Mon Sep 17 00:00:00 2001 From: Josh Bell Date: Mon, 18 Jul 2011 14:26:04 +0000 Subject: [PATCH 1/3] Resolved issue in ber.go at line 386 where reflect.NewValue was used instead of reflect.ValueOf. --- ber.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ber.go b/ber.go index 058fd48..8f32e24 100644 --- a/ber.go +++ b/ber.go @@ -383,7 +383,7 @@ func Encode( ClassType, TagType, Tag uint8, Value interface{}, Description strin p.Description = Description if Value != nil { - v := reflect.NewValue(Value) + v := reflect.ValueOf(Value) if ( ClassType == ClassUniversal ) { switch Tag { From d0cea65cc9ecfc965c69ef65ac6975262d148925 Mon Sep 17 00:00:00 2001 From: Josh Bell Date: Mon, 18 Jul 2011 15:29:50 +0000 Subject: [PATCH 2/3] Updated package to build away from mmitton's branch. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index acda29a..1e44d52 100644 --- a/Makefile +++ b/Makefile @@ -4,7 +4,7 @@ include $(GOROOT)/src/Make.inc -TARG=github.com/mmitton/asn1-ber +TARG=github.com/hsoj/asn1-ber GOFILES=\ ber.go\ From 76f71317fe6c7046bffeafb794cc5f48ed0159e0 Mon Sep 17 00:00:00 2001 From: Ian Davis Date: Tue, 3 Jul 2012 15:49:57 +0100 Subject: [PATCH 3/3] Fixed to work with Go 1. Replaced os.Error with builtin error type. --- ber.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ber.go b/ber.go index 8f32e24..ba72243 100644 --- a/ber.go +++ b/ber.go @@ -4,7 +4,6 @@ import ( "bytes" "fmt" "io" - "os" "reflect" ) @@ -167,7 +166,7 @@ func resizeBuffer( in []byte, new_size uint64 ) (out []byte) { return } -func readBytes( reader io.Reader, buf []byte ) os.Error { +func readBytes( reader io.Reader, buf []byte ) error { idx := 0 buflen := len( buf ) for idx < buflen { @@ -180,7 +179,7 @@ func readBytes( reader io.Reader, buf []byte ) os.Error { return nil } -func ReadPacket( reader io.Reader ) ( *Packet, os.Error) { +func ReadPacket( reader io.Reader ) ( *Packet, error) { buf := make([]byte, 2) err := readBytes( reader, buf ) if err != nil {