refactor: isolate console dashboard routes

Author: misunders2d

src/agentnet/console/dashboard_http.py

@@ -0,0 +1,96 @@
+"""Authenticated read-only administration console page routes."""
+
+from __future__ import annotations
+
+from collections.abc import Callable
+from typing import Any
+
+from starlette.requests import Request
+from starlette.responses import HTMLResponse, Response
+from starlette.routing import Route
+
+from agentnet.console.read_service import ConsoleReadService
+from agentnet.console.render import ConsoleRenderer
+from agentnet.console.session import ConsoleSessionStatus
+
+
+SessionResolver = Callable[[Request], ConsoleSessionStatus]
+MutationAuthorizer = Callable[[Request], Any]
+PageResponse = Callable[..., HTMLResponse]
+
+
+def create_console_dashboard_routes(
+    *,
+    read_service: ConsoleReadService,
+    renderer: ConsoleRenderer,
+    session_for: SessionResolver,
+    mutation_authorizer: MutationAuthorizer,
+    page_response: PageResponse,
+) -> list[Route]:
+    """Mount authenticated read-only console pages."""
+
+    async def home(request: Request) -> Response:
+        status = session_for(request)
+        return page_response(
+            renderer.home(
+                read_service.home(actor=status.actor),
+                mutation_authorizer(request),
+            )
+        )
+
+    async def servers_page(request: Request) -> Response:
+        status = session_for(request)
+        return page_response(
+            renderer.servers(
+                read_service.servers(actor=status.actor),
+                mutation_authorizer(request),
+            )
+        )
+
+    async def people_page(request: Request) -> Response:
+        status = session_for(request)
+        return page_response(
+            renderer.people(
+                read_service.people(actor=status.actor),
+                mutation_authorizer(request),
+            )
+        )
+
+    async def approvals_page(request: Request) -> Response:
+        status = session_for(request)
+        return page_response(
+            renderer.approvals(
+                read_service.approvals(actor=status.actor),
+                mutation_authorizer(request),
+            )
+        )
+
+    async def security_page(request: Request) -> Response:
+        status = session_for(request)
+        return page_response(
+            renderer.security(
+                read_service.security(actor=status.actor),
+                mutation_authorizer(request),
+            )
+        )
+
+    async def activity_page(request: Request) -> Response:
+        status = session_for(request)
+        return page_response(
+            renderer.activity(
+                read_service.activity(actor=status.actor),
+                mutation_authorizer(request),
+            )
+        )
+
+    return [
+        Route("/", home, methods=["GET"]),
+        Route("/servers", servers_page, methods=["GET"]),
+        Route("/people", people_page, methods=["GET"]),
+        Route("/approvals", approvals_page, methods=["GET"]),
+        Route("/security", security_page, methods=["GET"]),
+        Route("/activity", activity_page, methods=["GET"]),
+    ]
+
+
+__all__ = ["create_console_dashboard_routes"]

src/agentnet/console/http.py

@@ -17,6 +17,7 @@
 from starlette.responses import HTMLResponse, JSONResponse, RedirectResponse, Response, StreamingResponse
 from starlette.routing import Route
 
+from agentnet.console.dashboard_http import create_console_dashboard_routes
 from agentnet.console.headers import protected_headers
 from agentnet.console.models import InvitationCreationForm
 from agentnet.console.mutations import ConsoleMutationService
@@ -236,60 +237,6 @@ async def script(_request: Request) -> Response:
             },
         )
 
-    async def home(request: Request) -> Response:
-        status = session_for(request)
-        return page_response(
-            renderer.home(
-                read_service.home(actor=status.actor),
-                mutation_authorizer(request),
-            )
-        )
-
-    async def servers_page(request: Request) -> Response:
-        status = session_for(request)
-        return page_response(
-            renderer.servers(
-                read_service.servers(actor=status.actor),
-                mutation_authorizer(request),
-            )
-        )
-
-    async def people_page(request: Request) -> Response:
-        status = session_for(request)
-        return page_response(
-            renderer.people(
-                read_service.people(actor=status.actor),
-                mutation_authorizer(request),
-            )
-        )
-
-    async def approvals_page(request: Request) -> Response:
-        status = session_for(request)
-        return page_response(
-            renderer.approvals(
-                read_service.approvals(actor=status.actor),
-                mutation_authorizer(request),
-            )
-        )
-
-    async def security_page(request: Request) -> Response:
-        status = session_for(request)
-        return page_response(
-            renderer.security(
-                read_service.security(actor=status.actor),
-                mutation_authorizer(request),
-            )
-        )
-
-    async def activity_page(request: Request) -> Response:
-        status = session_for(request)
-        return page_response(
-            renderer.activity(
-                read_service.activity(actor=status.actor),
-                mutation_authorizer(request),
-            )
-        )
-
     async def sign_out(request: Request) -> Response:
         status, _ = await mutation_form(request)
         token = request.cookies.get(SESSION_COOKIE, "")
@@ -623,12 +570,17 @@ async def extension_error(_request: Request, exc: Exception) -> Response:
     )
     routes += [
         Route("/v1/console/sign-out", sign_out, methods=["POST"]),
-        Route("/", home, methods=["GET"]),
-        Route("/servers", servers_page, methods=["GET"]),
-        Route("/people", people_page, methods=["GET"]),
-        Route("/approvals", approvals_page, methods=["GET"]),
-        Route("/security", security_page, methods=["GET"]),
-        Route("/activity", activity_page, methods=["GET"]),
+    ]
+    routes.extend(
+        create_console_dashboard_routes(
+            read_service=read_service,
+            renderer=renderer,
+            session_for=session_for,
+            mutation_authorizer=mutation_authorizer,
+            page_response=page_response,
+        )
+    )
+    routes += [
         Route("/invitations/new", new_invitation, methods=["GET"]),
         Route("/invitations", create_invitation, methods=["POST"]),
         Route("/invitations/{invitation_id}", invitation_detail, methods=["GET"]),