Skip to content

Commit 363b799

Browse files
committed
fix(bindings): omit Pi-only flag for OMP
1 parent e2a51b8 commit 363b799

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

src/agentnet/bindings/remote_manager.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1070,12 +1070,15 @@ def _stage_manager_extension(
10701070
"packaged Manager extension could not be staged",
10711071
) from exc
10721072
staged[name] = target_path
1073+
builtin_tool_flags = (
1074+
("--no-builtin-tools",) if Path(command[0]).name == "pi" else ()
1075+
)
10731076
return (
10741077
*command,
10751078
"--extension",
10761079
str(staged["pi_extension.ts"]),
10771080
"--no-extensions",
1078-
"--no-builtin-tools",
1081+
*builtin_tool_flags,
10791082
"--tools",
10801083
",".join(_MANAGER_TOOL_NAMES),
10811084
)

tests/bindings/test_remote_manager.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,10 +1001,11 @@ def test_manager_command_rejects_unsupported_executable_and_owned_flags() -> Non
10011001
validate_manager_command((executable, *suffix))
10021002

10031003

1004-
@pytest.mark.parametrize("executable_name", ["pi", "omp"])
1004+
@pytest.mark.parametrize(("executable_name", "expected_no_builtin_tools"), [("pi", 1), ("omp", 0)])
10051005
def test_runner_stages_complete_extension_for_measured_node_manager_launcher(
10061006
tmp_path: Path,
10071007
executable_name: str,
1008+
expected_no_builtin_tools: int,
10081009
) -> None:
10091010
state_dir = tmp_path / "s"
10101011
state_dir.mkdir(mode=0o700)
@@ -1019,7 +1020,7 @@ def test_runner_stages_complete_extension_for_measured_node_manager_launcher(
10191020
const args = process.argv.slice(2);
10201021
assert.equal(args.filter((value) => value === "--extension").length, 1);
10211022
assert.equal(args.filter((value) => value === "--no-extensions").length, 1);
1022-
assert.equal(args.filter((value) => value === "--no-builtin-tools").length, 1);
1023+
assert.equal(args.filter((value) => value === "--no-builtin-tools").length, Number(args[3]));
10231024
assert.equal(args.filter((value) => value === "--tools").length, 1);
10241025
assert.equal(args[args.indexOf("--tools") + 1], args[2]);
10251026
const extension = args[args.indexOf("--extension") + 1];
@@ -1044,7 +1045,7 @@ def test_runner_stages_complete_extension_for_measured_node_manager_launcher(
10441045
status = run_manager_gateway(
10451046
RecordingClient({"items": []}),
10461047
lambda: _actor(),
1047-
(str(manager_executable), digest, response_digest, expected_tools),
1048+
(str(manager_executable), digest, response_digest, expected_tools, str(expected_no_builtin_tools)),
10481049
state_dir=state_dir,
10491050
environment={"LANG": "C.UTF-8", "PATH": os.environ.get("PATH", "/usr/bin:/bin")},
10501051
manager_extension=extension,

0 commit comments

Comments
 (0)