From 33d57d968129fe29a5e76a3b75a14ec6a72b48b2 Mon Sep 17 00:00:00 2001 From: Hyeoncheol Kim Date: Sun, 31 May 2026 21:14:34 +0900 Subject: [PATCH 1/6] Switch PR review to Hermes --- .github/workflows/zai-review.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/zai-review.yml b/.github/workflows/zai-review.yml index 217ef41..8b8bd46 100644 --- a/.github/workflows/zai-review.yml +++ b/.github/workflows/zai-review.yml @@ -1,4 +1,4 @@ -name: Z.ai PR Review +name: Hermes PR Review on: pull_request: @@ -13,10 +13,9 @@ on: permissions: contents: read pull-requests: write - id-token: write concurrency: - group: zai-review-${{ github.event.pull_request.number || inputs.pr_number || github.run_id }} + group: hermes-review-${{ github.event.pull_request.number || inputs.pr_number || github.run_id }} cancel-in-progress: true jobs: @@ -28,9 +27,8 @@ jobs: github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository ) - uses: midagedev/review-actions/.github/workflows/zai-pr-review.yml@v1 + uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@codex/hermes-pr-review with: pr_number: ${{ github.event.pull_request.number || inputs.pr_number }} prompt_path: .github/zai-review-prompt.md - secrets: - ZAI_API_KEY: ${{ secrets.ZAI_API_KEY }} + runner_labels: '["self-hosted","vps-hermes","billtap"]' From 35c526aefd78881582bd853a8b5e9f2cfeeecc38 Mon Sep 17 00:00:00 2001 From: Hyeoncheol Kim Date: Sun, 31 May 2026 21:20:43 +0900 Subject: [PATCH 2/6] Document Hermes clean-review behavior --- .github/workflows/zai-review.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/zai-review.yml b/.github/workflows/zai-review.yml index 8b8bd46..5c59e11 100644 --- a/.github/workflows/zai-review.yml +++ b/.github/workflows/zai-review.yml @@ -32,3 +32,4 @@ jobs: pr_number: ${{ github.event.pull_request.number || inputs.pr_number }} prompt_path: .github/zai-review-prompt.md runner_labels: '["self-hosted","vps-hermes","billtap"]' + approve_when_clean: false From 03209103658e178493c8044be367c8fb53a078c3 Mon Sep 17 00:00:00 2001 From: Hyeoncheol Kim Date: Sun, 31 May 2026 21:52:08 +0900 Subject: [PATCH 3/6] Use Hermes PR review v2 --- .github/workflows/zai-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/zai-review.yml b/.github/workflows/zai-review.yml index 5c59e11..ce86789 100644 --- a/.github/workflows/zai-review.yml +++ b/.github/workflows/zai-review.yml @@ -27,9 +27,9 @@ jobs: github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository ) - uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@codex/hermes-pr-review + uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@v2 with: pr_number: ${{ github.event.pull_request.number || inputs.pr_number }} prompt_path: .github/zai-review-prompt.md runner_labels: '["self-hosted","vps-hermes","billtap"]' - approve_when_clean: false + approve_when_clean: true From 0f75a7c95a70365e842ff69f9b257f9dcd5241f3 Mon Sep 17 00:00:00 2001 From: Hyeoncheol Kim Date: Sun, 31 May 2026 21:54:54 +0900 Subject: [PATCH 4/6] Use isolated Hermes review workflow --- .github/workflows/zai-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zai-review.yml b/.github/workflows/zai-review.yml index ce86789..6322d84 100644 --- a/.github/workflows/zai-review.yml +++ b/.github/workflows/zai-review.yml @@ -27,7 +27,7 @@ jobs: github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository ) - uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@v2 + uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@v3 with: pr_number: ${{ github.event.pull_request.number || inputs.pr_number }} prompt_path: .github/zai-review-prompt.md From 6587f0f70be611ee07df6e8eed7810d687b2dfea Mon Sep 17 00:00:00 2001 From: Hyeoncheol Kim Date: Sun, 31 May 2026 21:57:52 +0900 Subject: [PATCH 5/6] Use Hermes review workflow v4 --- .github/workflows/zai-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zai-review.yml b/.github/workflows/zai-review.yml index 6322d84..826833e 100644 --- a/.github/workflows/zai-review.yml +++ b/.github/workflows/zai-review.yml @@ -27,7 +27,7 @@ jobs: github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository ) - uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@v3 + uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@v4 with: pr_number: ${{ github.event.pull_request.number || inputs.pr_number }} prompt_path: .github/zai-review-prompt.md From b35282afedd22aa7d38bb639e4821ba4d92c9a76 Mon Sep 17 00:00:00 2001 From: Hyeoncheol Kim Date: Sun, 31 May 2026 22:00:34 +0900 Subject: [PATCH 6/6] Use Hermes review workflow v5 --- .github/workflows/zai-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/zai-review.yml b/.github/workflows/zai-review.yml index 826833e..1d72872 100644 --- a/.github/workflows/zai-review.yml +++ b/.github/workflows/zai-review.yml @@ -27,7 +27,7 @@ jobs: github.event.pull_request.draft == false && github.event.pull_request.head.repo.full_name == github.repository ) - uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@v4 + uses: midagedev/review-actions/.github/workflows/hermes-pr-review.yml@v5 with: pr_number: ${{ github.event.pull_request.number || inputs.pr_number }} prompt_path: .github/zai-review-prompt.md