refactor: convert overloaded private methods to #private

Manually inspect the 9 tool-skipped candidates from the private
member conversion. Getter/setter and method-overload declarations
that share a TypeScript symbol are known false positives in the
symbol-aware codemod: it flags every overload signature as an
'unsupported reference' to every other overload of the same method.

For AmazonS3Client's '_makeSignedRequestAsync' (3 overload
signatures) and HttpBuildCacheProvider's '_tryGetCredentialsAsync'
(4 overload signatures + implementation), a repo-wide search found
only ordinary same-class 'this.method(...)' call sites -- no
bracket access, 'as any' casts, reflection, prototype tricks, or
test spies. Converted every overload declaration and call site to
'#makeSignedRequestAsync' / '#tryGetCredentialsAsync'.

Left PlaywrightBrowserTunnel's 'status' accessor pair (public
getter / private setter) as TS-private: this is not a false
positive. Native ECMAScript private accessors have no way to make
only the setter private while the getter of the same name stays
public -- '#status' would need to be a single accessor pair with
uniform visibility, and it would collide with the existing
'#status' backing field. Converting it would require restructuring
the field name, which is outside the scope of a straightforward
private-to-# conversion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14

Author: bmiddha

rush-plugins/rush-amazon-s3-build-cache-plugin/src/AmazonS3Client.ts

@@ -153,7 +153,7 @@ export class AmazonS3Client {
   public async getObjectAsync(objectName: string): Promise<Buffer | undefined> {
     this.#writeDebugLine('Reading object from S3');
     return await this.#sendCacheRequestWithRetriesAsync(async () => {
-      const response: IWebClientResponse = await this._makeSignedRequestAsync('GET', objectName);
+      const response: IWebClientResponse = await this.#makeSignedRequestAsync('GET', objectName);
       return this.#handleGetResponseAsync(response, async () => await response.getBufferAsync());
     });
   }
@@ -164,7 +164,7 @@ export class AmazonS3Client {
     }
 
     await this.#sendCacheRequestWithRetriesAsync(async () => {
-      const response: IWebClientResponse = await this._makeSignedRequestAsync(
+      const response: IWebClientResponse = await this.#makeSignedRequestAsync(
         'PUT',
         objectName,
         objectBuffer
@@ -191,7 +191,7 @@ export class AmazonS3Client {
   public async downloadObjectToFileAsync(objectName: string, localFilePath: string): Promise<boolean> {
     this.#writeDebugLine('Downloading object from S3 to file');
     const result: boolean | undefined = await this.#sendCacheRequestWithRetriesAsync(async () => {
-      const response: IWebClientStreamResponse = await this._makeSignedRequestAsync(
+      const response: IWebClientStreamResponse = await this.#makeSignedRequestAsync(
         'GET',
         objectName,
         undefined,
@@ -229,7 +229,7 @@ export class AmazonS3Client {
     const entryStream: FileSystemReadStream = FileSystem.createReadStream(localFilePath);
 
     // Streaming uploads cannot be retried because the stream is consumed after the first attempt.
-    const response: IWebClientStreamResponse = await this._makeSignedRequestAsync(
+    const response: IWebClientStreamResponse = await this.#makeSignedRequestAsync(
       'PUT',
       objectName,
       entryStream as Readable,
@@ -318,20 +318,20 @@ export class AmazonS3Client {
     return new Error(`Amazon S3 responded with status code ${status} (${statusText})`);
   }
 
-  private async _makeSignedRequestAsync(
+  async #makeSignedRequestAsync(
     verb: 'GET' | 'PUT',
     objectName: string,
     body?: Buffer
   ): Promise<IWebClientResponse>;
-  private async _makeSignedRequestAsync(
+  async #makeSignedRequestAsync(
     verb: 'GET' | 'PUT',
     objectName: string,
     body: Readable | undefined,
     stream: true,
     contentHash?: string,
     contentLength?: number
   ): Promise<IWebClientStreamResponse>;
-  private async _makeSignedRequestAsync(
+  async #makeSignedRequestAsync(
     verb: 'GET' | 'PUT',
     objectName: string,
     body?: Buffer | Readable,

rush-plugins/rush-http-build-cache-plugin/src/HttpBuildCacheProvider.ts

@@ -405,7 +405,7 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
       stream
     } = options;
     const safeCredentialOptions: CredentialsOptions = credentialOptions ?? CredentialsOptions.Optional;
-    const credentials: string | undefined = await this._tryGetCredentialsAsync(safeCredentialOptions);
+    const credentials: string | undefined = await this.#tryGetCredentialsAsync(safeCredentialOptions);
     const url: string = new URL(relUrl, this.#url).href;
 
     const headers: Record<string, string> = {};
@@ -489,11 +489,11 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
     return response;
   }
 
-  private async _tryGetCredentialsAsync(options: CredentialsOptions.Required): Promise<string>;
-  private async _tryGetCredentialsAsync(options: CredentialsOptions.Optional): Promise<string | undefined>;
-  private async _tryGetCredentialsAsync(options: CredentialsOptions.Omit): Promise<undefined>;
-  private async _tryGetCredentialsAsync(options: CredentialsOptions): Promise<string | undefined>;
-  private async _tryGetCredentialsAsync(options: CredentialsOptions): Promise<string | undefined> {
+  async #tryGetCredentialsAsync(options: CredentialsOptions.Required): Promise<string>;
+  async #tryGetCredentialsAsync(options: CredentialsOptions.Optional): Promise<string | undefined>;
+  async #tryGetCredentialsAsync(options: CredentialsOptions.Omit): Promise<undefined>;
+  async #tryGetCredentialsAsync(options: CredentialsOptions): Promise<string | undefined>;
+  async #tryGetCredentialsAsync(options: CredentialsOptions): Promise<string | undefined> {
     if (options === CredentialsOptions.Omit) {
       return;
     }