Skip to content

Commit eb01554

Browse files
Use safe bump tag delimiter
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
1 parent fc3a7a4 commit eb01554

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

common/config/azure-pipelines/templates/bump-versions-stages.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# There is one bump pipeline per version policy; each of them builds the repo, bumps the versions
44
# for its own version policy, packs the resulting tarballs and opens a GitHub PR with the changes.
55
# The packed tarballs are published to the npm feed later by the matching "esrp publish" pipeline,
6-
# which locates this pipeline run via the "bump-versions:<sha>" build tag.
6+
# which locates this pipeline run via the "bump-versions|<sha>" build tag.
77

88
parameters:
99
- name: VersionPolicyName
@@ -104,7 +104,7 @@ stages:
104104
set -e
105105
BUMP_SHA=$(git rev-parse HEAD)
106106
echo "##vso[task.setvariable variable=BumpSha;isOutput=true]${BUMP_SHA}"
107-
echo "##vso[build.addbuildtag]bump-versions:${BUMP_SHA}"
107+
echo "##vso[build.addbuildtag]bump-versions|${BUMP_SHA}"
108108
echo "Tagged build with bump SHA: ${BUMP_SHA}"
109109
name: TagBuild
110110
displayName: 'Tag build with bump commit SHA'

common/config/azure-pipelines/templates/esrp-publish-stages.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# There is one publish pipeline per version policy. Each of them is triggered when the version bump
44
# PR produced by the matching bump pipeline is merged to main; it locates the originating bump
5-
# pipeline run (via the "bump-versions:<sha>" build tag) and publishes the tarballs that were packed
5+
# pipeline run (via the "bump-versions|<sha>" build tag) and publishes the tarballs that were packed
66
# by that run to the npm feed via ESRP.
77

88
parameters:

common/config/azure-pipelines/templates/find-bump-pipeline-run.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ steps:
7171
7272
echo "Found merged PR #${PR_NUMBER}; head SHA: ${HEAD_SHA}"
7373
74-
BUMP_TAG="bump-versions:${HEAD_SHA}"
74+
BUMP_TAG="bump-versions|${HEAD_SHA}"
7575
ENCODED_TAG=$(url_encode "$BUMP_TAG")
7676
BUILDS_URL="${SYSTEM_COLLECTIONURI}${{ parameters.TeamProject }}/_apis/build/builds?definitions=${PIPELINE_ID}&tagFilters=${ENCODED_TAG}&queryOrder=finishTimeDescending&\$top=1&api-version=7.1"
7777

0 commit comments

Comments
 (0)