Skip to content

Commit c8bbaae

Browse files
Copilotdmichon-msft
andcommitted
Address publish pipeline review feedback
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
1 parent 8881781 commit c8bbaae

4 files changed

Lines changed: 22 additions & 2 deletions

File tree

common/config/azure-pipelines/esrp-publish-rush.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ extends:
5757
stages:
5858
- template: /common/config/azure-pipelines/templates/esrp-publish-stages.yaml@self
5959
parameters:
60+
# https://dev.azure.com/RushStack/GitHubProjects/_build?definitionId=12
6061
BumpPipelineId: 12
6162
BumpPipelineProject: GitHubProjects
6263
StageNameSuffix: Rush

common/config/azure-pipelines/esrp-publish-rushstack.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ extends:
5757
stages:
5858
- template: /common/config/azure-pipelines/templates/esrp-publish-stages.yaml@self
5959
parameters:
60+
# https://dev.azure.com/RushStack/GitHubProjects/_build?definitionId=10
6061
BumpPipelineId: 10
6162
BumpPipelineProject: GitHubProjects
6263
StageNameSuffix: Rushstack

libraries/rush-lib/assets/rush-init/common/config/rush/[dot]npmrc

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,16 @@
1818
# It is NOT recommended to store authentication tokens in a text file on a lab machine, because
1919
# other unrelated processes may be able to read that file. Also, the file may persist indefinitely,
2020
# for example if the machine loses power. A safer practice is to pass the token via an
21-
# environment variable, which can be referenced from .npmrc using ${} expansion.
21+
# environment variable, which can be referenced from .npmrc using ${} expansion. For example:
22+
#
23+
# //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}
24+
#
25+
26+
# Explicitly specify the NPM registry that "rush install" and "rush update" will use by default:
27+
registry=https://registry.npmjs.org/
28+
29+
# Optionally provide an authentication token for the above registry URL (if it is a private registry):
30+
# //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}
2231

2332
# Change this to "true" if your registry requires authentication for read-only operations:
2433
always-auth=false

libraries/rush-lib/assets/rush-init/common/config/rush/[dot]npmrc-publish

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,13 @@
1414
# It is NOT recommended to store authentication tokens in a text file on a lab machine, because
1515
# other unrelated processes may be able to read the file. Also, the file may persist indefinitely,
1616
# for example if the machine loses power. A safer practice is to pass the token via an
17-
# environment variable, which can be referenced from .npmrc using ${} expansion.
17+
# environment variable, which can be referenced from .npmrc using ${} expansion. For example:
18+
#
19+
# //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}
20+
#
21+
22+
# Explicitly specify the NPM registry that "rush publish" will use by default:
23+
registry=https://registry.npmjs.org/
24+
25+
# Provide an authentication token for the above registry URL:
26+
# //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}

0 commit comments

Comments
 (0)