fixup! Add support for .env files.

Author: iclanton

libraries/rush-lib/src/cli/RushCommandLineParser.ts

@@ -131,7 +131,7 @@ export class RushCommandLineParser extends CommandLineParser {
       });
 
       if (EnvironmentConfiguration.hasBeenValidated) {
-        terminal.writeWarningLine(
+        throw new Error(
           `The ${EnvironmentConfiguration.name} was initialized before .env files were loaded. Rush environment ` +
             'variables may have unexpected values.'
         );

libraries/rush-lib/src/cli/actions/test/AddAction.test.ts

@@ -3,11 +3,13 @@
 
 import '../../test/mockRushCommandLineParser';
 
+import { LockFile } from '@rushstack/node-core-library';
+
 import { PackageJsonUpdater } from '../../../logic/PackageJsonUpdater';
 import type { IPackageJsonUpdaterRushAddOptions } from '../../../logic/PackageJsonUpdaterTypes';
 import { RushCommandLineParser } from '../../RushCommandLineParser';
 import { AddAction } from '../AddAction';
-import { LockFile } from '@rushstack/node-core-library';
+import { EnvironmentConfiguration } from '../../../api/EnvironmentConfiguration';
 
 describe(AddAction.name, () => {
   describe('basic "rush add" tests', () => {
@@ -32,6 +34,7 @@ describe(AddAction.name, () => {
       jest.clearAllMocks();
       process.exitCode = oldExitCode;
       process.argv = oldArgs;
+      EnvironmentConfiguration.reset();
     });
 
     describe("'add' action", () => {

libraries/rush-lib/src/cli/actions/test/RemoveAction.test.ts

@@ -3,13 +3,15 @@
 
 import '../../test/mockRushCommandLineParser';
 
+import { LockFile } from '@rushstack/node-core-library';
+
 import { PackageJsonUpdater } from '../../../logic/PackageJsonUpdater';
 import type { IPackageJsonUpdaterRushRemoveOptions } from '../../../logic/PackageJsonUpdaterTypes';
 import { RushCommandLineParser } from '../../RushCommandLineParser';
 import { RemoveAction } from '../RemoveAction';
 import { VersionMismatchFinderProject } from '../../../logic/versionMismatch/VersionMismatchFinderProject';
 import { DependencyType } from '../../../api/PackageJsonEditor';
-import { LockFile } from '@rushstack/node-core-library';
+import { EnvironmentConfiguration } from '../../../api/EnvironmentConfiguration';
 
 describe(RemoveAction.name, () => {
   describe('basic "rush remove" tests', () => {
@@ -36,6 +38,7 @@ describe(RemoveAction.name, () => {
       jest.clearAllMocks();
       process.exitCode = oldExitCode;
       process.argv = oldArgs;
+      EnvironmentConfiguration.reset();
     });
 
     describe("'remove' action", () => {

libraries/rush-lib/src/cli/test/CommandLineHelp.test.ts

@@ -4,6 +4,7 @@
 import { AnsiEscape } from '@rushstack/terminal';
 
 import { RushCommandLineParser } from '../RushCommandLineParser';
+import { EnvironmentConfiguration } from '../../api/EnvironmentConfiguration';
 
 describe('CommandLineHelp', () => {
   let oldCwd: string | undefined;
@@ -33,6 +34,8 @@ describe('CommandLineHelp', () => {
     if (oldCwd) {
       process.chdir(oldCwd);
     }
+
+    EnvironmentConfiguration.reset();
   });
 
   it('prints the global help', () => {

libraries/rush-lib/src/cli/test/RushCommandLineParser.test.ts

@@ -27,6 +27,7 @@ import { FileSystem, JsonFile, Path } from '@rushstack/node-core-library';
 import { Autoinstaller } from '../../logic/Autoinstaller';
 import type { ITelemetryData } from '../../logic/Telemetry';
 import { getCommandLineParserInstanceAsync } from './TestUtils';
+import { EnvironmentConfiguration } from '../../api/EnvironmentConfiguration';
 
 function pathEquals(actual: string, expected: string): void {
   expect(Path.convertToSlashes(actual)).toEqual(Path.convertToSlashes(expected));
@@ -40,6 +41,7 @@ describe('RushCommandLineParser', () => {
   describe('execute', () => {
     afterEach(() => {
       jest.clearAllMocks();
+      EnvironmentConfiguration.reset();
     });
 
     describe('in basic repo', () => {

libraries/rush-lib/src/cli/test/RushPluginCommandLineParameters.test.ts

@@ -7,6 +7,7 @@ import path from 'path';
 import { FileSystem, LockFile } from '@rushstack/node-core-library';
 import { RushCommandLineParser } from '../RushCommandLineParser';
 import { Autoinstaller } from '../../logic/Autoinstaller';
+import { EnvironmentConfiguration } from '../../api/EnvironmentConfiguration';
 
 describe('PluginCommandLineParameters', () => {
   let originCWD: string | undefined;
@@ -61,6 +62,8 @@ describe('PluginCommandLineParameters', () => {
       originCWD = undefined;
       process.argv = _argv;
     }
+
+    EnvironmentConfiguration.reset();
   });
 
   afterAll(() => {