Align shadow emission with the realigned reporter contracts

- Scoped reporters emit human messages on the messageEmitted channel with a
  fail-safe local-sensitive privacy default (was: activityChanged with a
  producer-set required flag, which was coalescible under pressure)
- Producers no longer set 'required'; the manager derives it from event type
- Register RUSH_PLUGIN_API_INCOMPATIBLE in the diagnostic registry with its
  template

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: TheLarkInn

common/reviews/api/rush-reporter.api.md

@@ -130,6 +130,13 @@ export const RUSH_DIAGNOSTIC_CODE_DEFINITIONS = [
     defaultSeverity: 'error',
     summaryKey: 'diagnostic.RUSH_INTERNAL_UNEXPECTED.summary',
     detailKey: 'diagnostic.RUSH_INTERNAL_UNEXPECTED.detail'
+  },
+  {
+    code: 'RUSH_PLUGIN_API_INCOMPATIBLE',
+    category: 'configuration',
+    defaultSeverity: 'error',
+    summaryKey: 'diagnostic.RUSH_PLUGIN_API_INCOMPATIBLE.summary',
+    detailKey: undefined
   }
 ] as const satisfies readonly IRushDiagnosticCodeDefinition[];
 

libraries/reporter/src/diagnostics/RushDiagnosticCodeRegistry.ts

@@ -10,5 +10,7 @@
  */
 // eslint-disable-next-line @typescript-eslint/typedef -- literal keys are required for the Record<RushDiagnosticTemplateKey, string> aggregate check
 export const CONFIGURATION_DIAGNOSTIC_TEMPLATES = {
-  'diagnostic.RUSH_CONFIG_INVALID_JSON.summary': 'The configuration file {file} contains invalid JSON.'
+  'diagnostic.RUSH_CONFIG_INVALID_JSON.summary': 'The configuration file {file} contains invalid JSON.',
+  'diagnostic.RUSH_PLUGIN_API_INCOMPATIBLE.summary':
+    'The plugin {pluginName} declares plugin API version {declaredApiVersion}, which is incompatible with this Rush (supported: {supportedApiVersion}).'
 } as const;

libraries/reporter/src/diagnostics/templates/configuration.ts

@@ -149,7 +149,6 @@ export class LifecycleEmitter {
       source: this._source,
       scope,
       privacy,
-      required: true,
       type,
       payload
     });

libraries/reporter/src/lifecycle/LifecycleEmitter.ts

@@ -66,16 +66,15 @@ export function createScopedReporter(options: ICreateScopedReporterOptions): ISc
 
   return {
     emitMessage(messageOptions: IScopedMessageOptions): string {
-      const required: boolean = messageOptions.severity === 'warning' || messageOptions.severity === 'error';
       return sink.emit({
         protocolVersion,
         sessionId,
         source,
         scope,
-        privacy: messageOptions.privacy ?? 'public',
-        required,
-        type: 'activityChanged',
-        payload: { kind: 'message', severity: messageOptions.severity, text: messageOptions.text }
+        // Message text fails safe at local-sensitive by default.
+        privacy: messageOptions.privacy ?? 'local-sensitive',
+        type: 'messageEmitted',
+        payload: { severity: messageOptions.severity, text: messageOptions.text }
       });
     },
 
@@ -89,7 +88,6 @@ export function createScopedReporter(options: ICreateScopedReporterOptions): ISc
         source,
         scope,
         privacy: computeEnvelopePrivacyFloor(classifications),
-        required: diagnostic.severity === 'error',
         type: 'diagnosticEmitted',
         payload: diagnostic
       });
@@ -105,7 +103,6 @@ export function createScopedReporter(options: ICreateScopedReporterOptions): ISc
         source,
         scope,
         privacy: 'public',
-        required: false,
         type: 'extension',
         payload: { name, payload }
       });

libraries/reporter/src/session/ScopedReporterFactory.ts

@@ -7,6 +7,7 @@ import {
   summarizeShadowResult,
   createRushDiagnostic,
   ReporterManager,
+  isReporterEventRequired,
   type IReporter,
   type IReporterEventEnvelope,
   type IReporterEventSink,
@@ -63,7 +64,8 @@ describe('LifecycleEmitter', () => {
     emitter.emitOperationRegistered({ operationId: 'op1', projectName: 'p', phaseName: '_phase:build' });
 
     expect(sink.inputs[0].type).toBe('operationRegistered');
-    expect(sink.inputs[0].required).toBe(true);
+    // Lifecycle events are protected; the manager derives `required` from the type.
+    expect(isReporterEventRequired('operationRegistered')).toBe(true);
     expect(sink.inputs[0].scope).toEqual({
       commandName: 'build',
       operationId: 'op1',
@@ -82,7 +84,7 @@ describe('LifecycleEmitter', () => {
     );
     expect(sink.inputs[0].type).toBe('diagnosticEmitted');
     expect(sink.inputs[0].privacy).toBe('local-sensitive');
-    expect(sink.inputs[0].required).toBe(true);
+    expect(isReporterEventRequired('diagnosticEmitted')).toBe(true);
   });
 
   it('writes nothing to stdout or stderr while events flow (shadow mode)', () => {

libraries/reporter/src/test/Lifecycle.test.ts

@@ -10,6 +10,7 @@ import {
   RUSH_PLUGIN_API_VERSION,
   isPluginApiVersionSupported,
   createPluginApiIncompatibleDiagnostic,
+  isReporterEventRequired,
   type IReporter,
   type IReporterEventEnvelope,
   type IReporterEventScope,
@@ -65,19 +66,24 @@ describe('createScopedReporter', () => {
     });
 
     reporter.emitMessage({ severity: 'info', text: 'hello' });
-    expect(sink.inputs[0].type).toBe('activityChanged');
+    expect(sink.inputs[0].type).toBe('messageEmitted');
     expect(sink.inputs[0].scope).toEqual(scope);
-    expect(sink.inputs[0].required).toBe(false);
-    expect(sink.inputs[0].payload).toEqual({ kind: 'message', severity: 'info', text: 'hello' });
+    // The manager derives `required`; messages are never coalescible.
+    expect(isReporterEventRequired('messageEmitted')).toBe(true);
+    // Message text fails safe at local-sensitive by default.
+    expect(sink.inputs[0].privacy).toBe('local-sensitive');
+    expect(sink.inputs[0].payload).toEqual({ severity: 'info', text: 'hello' });
   });
 
-  it('marks warning and error messages as required', () => {
+  it('emits messages on the messageEmitted channel for every severity', () => {
     const sink: CapturingSink = new CapturingSink();
     const reporter: IScopedReporter = createScopedReporter({ sink, sessionId: 'sess', source: SOURCE });
     reporter.emitMessage({ severity: 'warning', text: 'careful' });
     reporter.emitMessage({ severity: 'error', text: 'boom' });
-    expect(sink.inputs[0].required).toBe(true);
-    expect(sink.inputs[1].required).toBe(true);
+    expect(sink.inputs[0].type).toBe('messageEmitted');
+    expect(sink.inputs[0].payload).toEqual({ severity: 'warning', text: 'careful' });
+    expect(sink.inputs[1].type).toBe('messageEmitted');
+    expect(sink.inputs[1].payload).toEqual({ severity: 'error', text: 'boom' });
   });
 
   it('emits diagnostics with the envelope privacy floor', () => {
@@ -93,7 +99,7 @@ describe('createScopedReporter', () => {
     expect(sink.inputs[0].type).toBe('diagnosticEmitted');
     // Least sensitive field is the floor.
     expect(sink.inputs[0].privacy).toBe('public');
-    expect(sink.inputs[0].required).toBe(true);
+    expect(isReporterEventRequired('diagnosticEmitted')).toBe(true);
     expect(sink.inputs[0].payload).toBe(diagnostic);
   });
 
@@ -103,7 +109,9 @@ describe('createScopedReporter', () => {
     reporter.emitExtension('acme.cache-warmed', { hits: 3 });
     expect(sink.inputs[0].type).toBe('extension');
     expect(sink.inputs[0].payload).toEqual({ name: 'acme.cache-warmed', payload: { hits: 3 } });
-    expect(() => reporter.emitExtension('notnamespaced', {})).toThrow(/Invalid extension event name/);
+    expect(() => reporter.emitExtension('notnamespaced' as Parameters<IScopedReporter['emitExtension']>[0], {})).toThrow(
+      /Invalid extension event name/
+    );
   });
 
   it('exposes only emit methods, hiding modes, destinations, and thresholds', () => {

libraries/reporter/src/test/Session.test.ts

@@ -46,7 +46,6 @@ function rawInput(type: string, payload: unknown): IReporterEmitEventInput<unkno
     sessionId: 'sess',
     source: SOURCE,
     privacy: 'public',
-    required: false,
     type: type as IReporterEmitEventInput<unknown>['type'],
     payload
   };