Skip to content

Commit fbd4e2f

Browse files
safaceroCopilot
andcommitted
Fix SymbolCheck failures: always archive nodejstools symbols to Symweb
The VS insertion job's MicroBuildInsertVsPayload@5 step reports a failure *after* successfully creating the auto-complete PR, because SubmitPullRequest.exe throws 'does not look like an Azure DevOps url' when copying commits / linking work items from the GitHub build joburi (nodejstools is a GitHub repo). That failure caused the downstream 'Download symbolsToArchive' and 'Archive symbols to Symweb' steps (default condition: succeeded()) to be skipped, so symbols were never published to Symweb. As a result every signed build failed the VS SymbolCheck gate, filing recurring 'SymbolCheck: Package ... failed' bugs for the NodejsTools and TestAdapter packages (e.g. AB#3025876, AB#3025877, AB#3026073, AB#3026074). - Set AddCommitsToPR:false and LinkWorkItemsToPR:false on MicroBuildInsertVsPayload@5 to avoid the GitHub-joburi crash (same pattern used by other GitHub-sourced VS insertions such as dotnet/fsharp). - Add condition: succeededOrFailed() to the symbol download + archive steps so symbols are always published to Symweb regardless of the insert step result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 3f6316b commit fbd4e2f

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

azure-pipelines/build-insertion.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,25 @@ extends:
7878
InsertAutoComplete: true
7979
ConnectedVSDropServiceName: 'VSEng-VSDrop-MI'
8080
TargetBranch: ${{ parameters.VSInsertTargetBranch }}
81+
# nodejstools is hosted on GitHub, not Azure DevOps. The MicroBuild SubmitPullRequest
82+
# tool crashes (System.ArgumentException: '<github url>' does not look like an Azure DevOps url)
83+
# when it tries to copy commits / link work items from the GitHub build joburi, which fails
84+
# the step *after* the PR is already created and skips the symbol-archive steps below.
85+
# Disable both to match the pattern used by other GitHub-sourced VS insertions (e.g. dotnet/fsharp).
86+
AddCommitsToPR: false
87+
LinkWorkItemsToPR: false
8188
env:
8289
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
8390
- download: projectSystemBuild
8491
artifact: symbolsToArchive
8592
displayName: 🔻 Download symbolsToArchive artifact
93+
# Always publish symbols to Symweb, even if a preceding step (e.g. Insert VS Payload)
94+
# reports a non-fatal failure. Otherwise symbols are never archived and the package
95+
# fails the VS SymbolCheck gate (filing "SymbolCheck: Package ... failed" bugs every build).
96+
condition: succeededOrFailed()
8697
- task: MicroBuildArchiveSymbols@6
8798
displayName: 🔣 Archive symbols to Symweb
99+
condition: succeededOrFailed()
88100
inputs:
89101
TeamName: Node Tools for Visual Studio
90102
azureSubscription: 'VSEng-SymbolsUpload' # SERVICE CONNECTION

0 commit comments

Comments
 (0)