Commit fbd4e2f
Fix SymbolCheck failures: always archive nodejstools symbols to Symweb
The VS insertion job's MicroBuildInsertVsPayload@5 step reports a failure
*after* successfully creating the auto-complete PR, because SubmitPullRequest.exe
throws 'does not look like an Azure DevOps url' when copying commits / linking
work items from the GitHub build joburi (nodejstools is a GitHub repo). That
failure caused the downstream 'Download symbolsToArchive' and
'Archive symbols to Symweb' steps (default condition: succeeded()) to be skipped,
so symbols were never published to Symweb. As a result every signed build failed
the VS SymbolCheck gate, filing recurring 'SymbolCheck: Package ... failed' bugs
for the NodejsTools and TestAdapter packages (e.g. AB#3025876, AB#3025877,
AB#3026073, AB#3026074).
- Set AddCommitsToPR:false and LinkWorkItemsToPR:false on MicroBuildInsertVsPayload@5
to avoid the GitHub-joburi crash (same pattern used by other GitHub-sourced VS
insertions such as dotnet/fsharp).
- Add condition: succeededOrFailed() to the symbol download + archive steps so
symbols are always published to Symweb regardless of the insert step result.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 3f6316b commit fbd4e2f
1 file changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
81 | 88 | | |
82 | 89 | | |
83 | 90 | | |
84 | 91 | | |
85 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
86 | 97 | | |
87 | 98 | | |
| 99 | + | |
88 | 100 | | |
89 | 101 | | |
90 | 102 | | |
| |||
0 commit comments