Skip to content

Commit f8fec89

Browse files
YunchuWangCopilot
andcommitted
ci(functions-e2e): keep suite on workflow_dispatch while error-fidelity gaps remain
Revert the pull_request trigger added in 2982f34 (keeping that commit's build-order fix and file:-linking comment updates). The consolidated gRPC path still has 11 known error-text/status fidelity gaps in the ported specs -- not-found message wording, activity-failure prefixes, and terminal-op 400-vs-200 semantics -- which would make an automatic pull_request run red. Those gaps are tracked separately; until they are addressed the suite runs on manual dispatch only and does not gate PRs. Also quote the "Build ... for file: linking" step name so the workflow is valid YAML: an unquoted plain scalar containing ": " is rejected by spec-compliant parsers, which would otherwise block workflow_dispatch as well. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e5be22b-b727-4ccf-8668-60397bb403a0
1 parent 273868c commit f8fec89

2 files changed

Lines changed: 11 additions & 13 deletions

File tree

.github/workflows/functions-e2e-tests.yaml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,19 @@ name: 🧪 Functions Host E2E Tests
1212
# below we install and start both, so the suite runs for real; the self-skip is
1313
# the safety net that keeps the job green if a prerequisite fails to come up.
1414
#
15-
# Triggering: this suite runs automatically on pull requests that touch the
16-
# Functions surface (`test/e2e-functions/**`, `packages/azure-functions-durable/**`,
17-
# or this workflow file), and can also be started ad hoc from the Actions tab via
18-
# "Run workflow" (workflow_dispatch). It is intentionally scoped to the Functions
19-
# surface and does NOT gate core-only PRs, which have their own suites. NOTE:
15+
# Triggering: this suite is run ad hoc (manual dispatch) only for now. The ported
16+
# specs still have 11 known error-text/status fidelity gaps on the consolidated
17+
# gRPC path, which would make an automatic `pull_request` run red, so it does not
18+
# gate PRs yet; those gaps are tracked separately and the trigger will be
19+
# re-enabled once they are addressed. Start it from the Actions tab via "Run
20+
# workflow" (workflow_dispatch). To re-enable automatic runs later, add a
21+
# `pull_request` trigger scoped to `test/e2e-functions/**`,
22+
# `packages/azure-functions-durable/**`, and this workflow file. NOTE:
2023
# workflow_dispatch only appears in the Actions UI once this file exists on the
2124
# repository's default branch.
2225

2326
on:
2427
workflow_dispatch:
25-
pull_request:
26-
paths:
27-
- "test/e2e-functions/**"
28-
- "packages/azure-functions-durable/**"
29-
- ".github/workflows/functions-e2e-tests.yaml"
3028

3129
permissions:
3230
contents: read
@@ -59,7 +57,7 @@ jobs:
5957
# Build the in-repo compat package (`durable-functions`); its build script
6058
# runs `build:core` first, so this also builds `packages/durabletask-js` into
6159
# dist/. Both must exist before the test-app's `file:`-linked install below.
62-
- name: 🏗️ Build in-repo durable-functions (+ core) for file: linking
60+
- name: "🏗️ Build in-repo durable-functions (+ core) for file: linking"
6361
run: npm run build -w durable-functions
6462

6563
- name: 🔧 Install Azurite and Azure Functions Core Tools

test/e2e-functions/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ so it is safe to leave wired into CI and to run locally without setup:
3939
**not** part of the default `npm test` / workspaces test run, nor of
4040
`test:e2e:internal` (which is scoped to `tests/e2e`).
4141
- **CI**`.github/workflows/functions-e2e-tests.yaml` installs `func` + Azurite,
42-
installs/builds the test-app, and runs the suite on PRs that touch
43-
`test/e2e-functions/**`. The self-skip is the safety net if a prerequisite fails
42+
installs/builds the test-app, and runs the suite on manual dispatch
43+
(`workflow_dispatch`). The self-skip is the safety net if a prerequisite fails
4444
to come up.
4545

4646
## What it covers

0 commit comments

Comments
 (0)