Abruptly closed Session prevents restart

[hultqvist]

Windows Version

Microsoft Windows [Version 10.0.26200.8655]

WSL Version

2.9.3.0

Are you using WSL 1 or WSL 2?

• WSL 2
• WSL 1

Kernel Version

WSLC

Distro Version

WSLC

Other Software

NuGet: Microsoft.WSL.Containers 2.9.3

Repro Steps

1. Put a breakpoint at the exception
2. When hitting the breakpoint, stop the project, don't allow it to dispose or terminate.
3. Start the program again

var sessionSettings = new SessionSettings("BugSession", Config.RootDataPath)
{
    CpuCount = 2,
    MemorySizeInMB = 2048,
};
using var session = new Session(sessionSettings);
try
{
    session.Start();
    
    foreach(var img in session.GetImages())
        Console.WriteLine(img.Name);
    
    throw new NotImplementedException();
}
finally
{
    session.Terminate();
}

Expected Behavior

Connect to the existing session or force close and start a new one.

Actual Behavior

Upon the second run, after the abrupt stop, I get the following error message.

System.Runtime.InteropServices.COMException: 'Cannot create a file when that file already exists.

Cannot create a file when that file already exists.
'

Diagnostic Logs

No response

[github-actions]

Logs are required for review from WSL team

If this a feature request, please reply with '/feature'. If this is a question, reply with '/question'.
Otherwise, please attach logs by following the instructions below, your issue will not be reviewed unless they are added. These logs will help us understand what is going on in your machine.

How to collect WSL logs

Download and execute collect-wsl-logs.ps1 in an administrative powershell prompt:

Invoke-WebRequest -UseBasicParsing "https://raw.githubusercontent.com/microsoft/WSL/master/diagnostics/collect-wsl-logs.ps1" -OutFile collect-wsl-logs.ps1
Set-ExecutionPolicy Bypass -Scope Process -Force
.\collect-wsl-logs.ps1

The script will output the path of the log file once done.

If this is a networking issue, please use .\collect-wsl-logs.ps1 -LogProfile networking instead, following the instructions in Collect WSL logs for networking issues

Once completed please upload the output files to this GitHub issue.

See Collect WSL logs (recommended method).

If you choose to email these logs instead of attaching them to the bug, please send them to wsl-gh-logs@microsoft.com with the GitHub issue number in the subject, and include a link to your GitHub issue comment in the message body, and reply with '/emailed-logs'.

[hultqvist]

Logs sent

[florelis]

Since the calling process ends without terminating the session, the service keeps it running. So, on the second run, the session is still running on the service. The service is checking to see if a session with the given name already exists, and fails with this error unless we pass in the WSLCSessionFlagsOpenExisting flag from the SDK, but we never do that.

@JohnMcPMS Should we expose this in the SDK? Although I could see the case for not wanting to allow other processes to touch a session. Maybe we could make the service better at detecting when a caller disconnects, and then terminate the session.