Skip to content
This repository was archived by the owner on Mar 22, 2022. It is now read-only.
This repository was archived by the owner on Mar 22, 2022. It is now read-only.

The document typo for C# tutorial (UWP) at "A custom signaling solution" session. #856

Description

@JamestsaiTW

Describe the bug
https://microsoft.github.io/MixedReality-WebRTC/manual/cs/helloworld-cs-signaling-uwp.html

Document typos.

To Reproduce
Steps to reproduce the behavior:

At Step 4, code is:
private void Peer_LocalSdpReadytoSend(SdpMessage message) { var msg = NodeDssSignaler.FromSdpMessage(message); _signaler.SendMessageAsync(msg); }
private void Peer_IceCandidateReadytoSend(IceCandidate iceCandidate) { var msg = NodeDssSignaler.FromIceCandidate(iceCandidate); _signaler.SendMessageAsync(msg); }

image

Expected behavior
It should be:
private void Peer_LocalSdpReadytoSend(SdpMessage message) { var msg = NodeDssSignaler.Message.FromSdpMessage(message); _signaler.SendMessageAsync(msg); }
private void Peer_IceCandidateReadytoSend(IceCandidate iceCandidate) { var msg = NodeDssSignaler.Message.FromIceCandidate(iceCandidate); _signaler.SendMessageAsync(msg); }

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions