Skip to content

Commit 642a694

Browse files
committed
Remember dismissed setup picker
1 parent 6f02fa0 commit 642a694

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

docs/architecture/agentConfigurationManager.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ url = "http://localhost:3001/mcp"
7171

7272
### Popup State
7373

74-
Uses VS Code's `globalState` to track whether the onboarding popup has been shown, preventing repeated prompts on every activation.
74+
Uses VS Code's `globalState` to track whether the onboarding popup has been shown or dismissed, preventing repeated prompts on every activation. Users can still reopen setup from the Command Palette.
7575

7676
### Skill delivery — standard skills directories
7777

@@ -100,7 +100,7 @@ This fixes issue #105: earlier builds copied the skill next to each agent's conf
100100
3. If not, display multi-select dialog with supported agents
101101
4. For each selected agent, write/update config file
102102
5. Show success message with option to open config file
103-
6. Mark popup as shown
103+
6. Mark popup as shown after it is accepted or dismissed
104104

105105
The bundled `debug-live` skill is installed into the standard skills directories (`~/.agents/skills/`, plus `~/.copilot/skills/` when present) during step 4, so every skills-compatible harness discovers it from one shared location.
106106

src/utils/agentConfigurationManager.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,10 @@ export class AgentConfigurationManager {
589589
quickPick.canSelectMany = true;
590590
quickPick.ignoreFocusOut = true;
591591

592+
let accepted = false;
593+
592594
quickPick.onDidAccept(async () => {
595+
accepted = true;
593596
const selectedItems = quickPick.selectedItems;
594597
quickPick.hide();
595598

@@ -610,7 +613,12 @@ export class AgentConfigurationManager {
610613
await this.context.globalState.update(this.POPUP_SHOWN_KEY, true);
611614
});
612615

613-
quickPick.onDidHide(() => quickPick.dispose());
616+
quickPick.onDidHide(async () => {
617+
quickPick.dispose();
618+
if (!accepted) {
619+
await this.context.globalState.update(this.POPUP_SHOWN_KEY, true);
620+
}
621+
});
614622
quickPick.show();
615623
}
616624

0 commit comments

Comments
 (0)