Merge pull request #173 from mi-examples/pp-3449-coderabbit-fixes

fix: address CodeRabbit review findings (distZip gate, socket leak, send overload, outbox cap)

Author: sergak01

src/cli.ts

@@ -608,6 +608,7 @@ cli
           proxyCacheTTL = 600000,
           personalAccessToken = process.env.MI_ACCESS_TOKEN,
           miHudLess = false,
+          distZip = true,
         } = ppDevConfig;
 
         const appId: number =
@@ -1044,14 +1045,17 @@ cli
             // Fall back to defaults if the project package.json is unreadable.
           }
 
-          const distService = new DistService(templateName ?? basename(projectRoot), {
-            nextBuild: {
-              projectRoot,
-              distDir: nextExportDir,
-              packageVersion: nextPackageVersion,
-              packageRepositoryUrl: nextPackageRepositoryUrl,
-            },
-          });
+          const distService =
+            distZip !== false
+              ? new DistService(templateName ?? basename(projectRoot), {
+                  nextBuild: {
+                    projectRoot,
+                    distDir: nextExportDir,
+                    packageVersion: nextPackageVersion,
+                    packageRepositoryUrl: nextPackageRepositoryUrl,
+                  },
+                })
+              : undefined;
 
           // Minimal ViteDevServer shape consumed by ClientService (`ws` + the v7 flag).
           const clientServiceServer = {
@@ -1073,6 +1077,8 @@ cli
 
             if (nextUpgradeHandler) {
               nextUpgradeHandler(req, socket, head);
+            } else {
+              socket.destroy();
             }
           });
 

src/client/hot-context.ts

@@ -21,6 +21,8 @@ type CustomMessage = { type: 'custom'; event: string; data?: unknown };
 
 type Handler = (payload: any) => void;
 
+const MAX_OUTBOX_SIZE = 50;
+
 function resolveWebSocketUrl(): string {
   const { protocol, host } = window.location;
   const wsProtocol = protocol === 'https:' ? 'wss:' : 'ws:';
@@ -141,6 +143,9 @@ export function createPPDevHotContext(): ViteHotContext {
       if (socket && socket.readyState === WebSocket.OPEN) {
         socket.send(payload);
       } else {
+        if (outbox.length >= MAX_OUTBOX_SIZE) {
+          outbox.shift();
+        }
         outbox.push(payload);
       }
     },

src/lib/pp-ws-server.ts

@@ -71,6 +71,14 @@ export class PPDevHotServer {
           for (const socket of this.clients.keys()) {
             this.sendToSocket(socket, arg1, arg2);
           }
+        } else {
+          // send(payload: unknown) overload — broadcast the pre-built payload as-is.
+          const data = JSON.stringify(arg1);
+          for (const socket of this.clients.keys()) {
+            if (socket.readyState === WebSocket.OPEN) {
+              socket.send(data);
+            }
+          }
         }
       },
     };

tests/integration/middleware/load-pp-data.spec.ts

@@ -75,7 +75,7 @@ describe('initLoadPPData — load on deep-linked sub-path navigation', () => {
 
       expect(getPageVariables).toHaveBeenCalledTimes(1);
     } finally {
-      server.close();
+      await new Promise<void>((resolve) => server.close(() => resolve()));
     }
   });
 
@@ -87,7 +87,7 @@ describe('initLoadPPData — load on deep-linked sub-path navigation', () => {
 
       expect(getPageVariables).toHaveBeenCalledTimes(1);
     } finally {
-      server.close();
+      await new Promise<void>((resolve) => server.close(() => resolve()));
     }
   });
 
@@ -99,7 +99,7 @@ describe('initLoadPPData — load on deep-linked sub-path navigation', () => {
 
       expect(getPageVariables).not.toHaveBeenCalled();
     } finally {
-      server.close();
+      await new Promise<void>((resolve) => server.close(() => resolve()));
     }
   });
 
@@ -111,7 +111,7 @@ describe('initLoadPPData — load on deep-linked sub-path navigation', () => {
 
       expect(getPageVariables).not.toHaveBeenCalled();
     } finally {
-      server.close();
+      await new Promise<void>((resolve) => server.close(() => resolve()));
     }
   });
 });

tests/integration/middleware/pp-ws-server.spec.ts

@@ -96,6 +96,10 @@ describe('PPDevHotServer transport', () => {
 
       const message = await nextMessage(sender);
 
+      // Yield a full event-loop tick so any unintended broadcast would arrive at
+      // `other` before we assert isolation.
+      await new Promise<void>((resolve) => setImmediate(resolve));
+
       expect(message.event).toBe('info-data:response');
       expect(otherReceived).toBe(false);
     } finally {