From c24db194d29a8d19972fa3542057d3fddae88d6e Mon Sep 17 00:00:00 2001 From: Max Heidinger Date: Mon, 13 Jul 2026 09:24:19 +0200 Subject: [PATCH] fix: remove some hoverable links to hopefully fix freezes --- PReek.xcodeproj/project.pbxproj | 4 +-- .../PullRequestHeaderView.swift | 30 +++++++------------ 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/PReek.xcodeproj/project.pbxproj b/PReek.xcodeproj/project.pbxproj index e4a75b5..c6de956 100644 --- a/PReek.xcodeproj/project.pbxproj +++ b/PReek.xcodeproj/project.pbxproj @@ -509,7 +509,7 @@ "@executable_path/../Frameworks", ); MACOSX_DEPLOYMENT_TARGET = 26.0; - MARKETING_VERSION = 0.6.2; + MARKETING_VERSION = 0.6.3; PRODUCT_BUNDLE_IDENTIFIER = "de.max-heidinger.PReek"; PRODUCT_NAME = "$(TARGET_NAME)"; PROVISIONING_PROFILE_SPECIFIER = ""; @@ -552,7 +552,7 @@ "@executable_path/../Frameworks", ); MACOSX_DEPLOYMENT_TARGET = 26.0; - MARKETING_VERSION = 0.6.2; + MARKETING_VERSION = 0.6.3; PRODUCT_BUNDLE_IDENTIFIER = "de.max-heidinger.PReek"; PRODUCT_NAME = "$(TARGET_NAME)"; PROVISIONING_PROFILE_SPECIFIER = ""; diff --git a/PReek/Views/PullRequestViews/DisclosureGroupList/PullRequestHeaderView.swift b/PReek/Views/PullRequestViews/DisclosureGroupList/PullRequestHeaderView.swift index d167af9..1451ac9 100644 --- a/PReek/Views/PullRequestViews/DisclosureGroupList/PullRequestHeaderView.swift +++ b/PReek/Views/PullRequestViews/DisclosureGroupList/PullRequestHeaderView.swift @@ -34,7 +34,7 @@ struct PullRequestHeaderView: View, Equatable { HStack { HoverableLink(pullRequest.repository.name, destination: pullRequest.repository.url) .foregroundStyle(.primary) - HoverableLink(pullRequest.numberFormatted, destination: pullRequest.url) + Text(pullRequest.numberFormatted) .foregroundColor(.secondary) } @@ -68,18 +68,10 @@ struct PullRequestHeaderView: View, Equatable { var details: some View { HStack(spacing: 5) { - Group { - if let authorUrl = pullRequest.author.url { - HoverableLink(destination: authorUrl) { - authorText - } - } else { - authorText + authorText + .if(pullRequest.author.login != pullRequest.author.displayName) { view in + view.help(pullRequest.author.login) } - } - .if(pullRequest.author.login != pullRequest.author.displayName) { view in - view.help(pullRequest.author.login) - } Text("·") @@ -87,15 +79,13 @@ struct PullRequestHeaderView: View, Equatable { Text("·") - HoverableLink(destination: pullRequest.filesUrl) { - HStack(spacing: 2) { - Text(pullRequest.additionsFormatted) - .foregroundStyle(.success) - Text(pullRequest.deletionsFormatted) - .foregroundStyle(.failure) - } - .drawingGroup() // Prevent MacOS to randomly draw this upside down + HStack(spacing: 2) { + Text(pullRequest.additionsFormatted) + .foregroundStyle(.success) + Text(pullRequest.deletionsFormatted) + .foregroundStyle(.failure) } + .drawingGroup() // Prevent MacOS to randomly draw this upside down if !pullRequest.approvalFrom.isEmpty || !pullRequest.changesRequestedFrom.isEmpty { Text("·")