Syntax coloring for effective dates

[alensiljak]

When secondary (or effective) dates are used, the coloring breaks down:

[alensiljak]

Thanks!

[mhansen]

May god have mercy upon my soul for these regular expression crimes... 2b51056#diff-89b42d1b3542ae0696e5a3816ce607372c14d198667fd9ad5fef318867385990R29 :-)

[alensiljak]

I didn't dare touch it!

[mhansen]

I'm thankful for a test suite that'll hopefully tell me if I screw it up too bad.

Should be released soon in v0.0.10: https://marketplace.visualstudio.com/items?itemName=mark-hansen.hledger-vscode

[alensiljak]

You are aware of the saying: "If you have a problem, and you need Regular Expressions to solve it, then you have two problems."

[alensiljak]

Still white?

[mhansen]

Can you confirm you've updated to 0.0.10? Can you share the entire transaction too, I can add a test for it.

[alensiljak]

Sure.

The transaction is nothing special, really:

2022-01-07=2021-12-01 BBN Tax Adjustment
    Expenses:Tax:Withholding:Aus
    Assets:Investments:Aus:Cash USD  0.66 USD

I've also checked the regex and the groups seem ok. The tmGrammar docs indicate that having duplicate tokens is fine. I'm sorry I'm of not much help.

[alensiljak]

Adding an equals sign after the date immediately removes the coloring. I guess it requires some kind of separator, like space?

[mhansen]

Ah, bother. Not as easy to fix as I'd hoped. I probably won't have time to pursue this one anytime soon sorry

…

On Tue, 8 Nov 2022 at 21:18, Alen Šiljak ***@***.***> wrote: Adding an equals sign after the date immediately removes the coloring. I guess it requires some kind of separator, like space? — Reply to this email directly, view it on GitHub <#260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZYONYEOSFDI46CQOBZVTWHISI7ANCNFSM6AAAAAARZAC7UY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[alensiljak]

Understood. I was hoping, too, that the Regex addition was enough.