Fix float values (#70)

* Output floats too

* Add error print

* Remove quotes

* Debug

* Tidy up

* Fix test

* Remove outdated comment

* Fix error logging

Co-authored-by: Kartik Ohri <kartikohri13@gmail.com>

Author: mayhem

brainzutils/metrics.py

@@ -1,6 +1,7 @@
 from functools import wraps
 import os
 import socket
+import logging
 from time import time_ns
 from typing import Dict
 
@@ -58,6 +59,8 @@ def set(metric_name: str, tags: Dict[str, str] = None, timestamp: int = None, **
     for k, v in fields.items():
         if type(v) == int:
             fields_list.append("%s=%di" % (k, v))
+        elif type(v) == float:
+            fields_list.append('%s=%f' % (k, v))
         elif type(v) == bool:
             val = "t" if v else "f"
             fields_list.append("%s=%s" % (k, val))
@@ -75,5 +78,4 @@ def set(metric_name: str, tags: Dict[str, str] = None, timestamp: int = None, **
     try:
         cache._r.rpush(REDIS_METRICS_KEY, metric)
     except Exception:
-        # If we fail to push the metric to redis, so be it.
-        pass
+        logging.error("Cannot set redis metric:", exc_info=True)

brainzutils/test/test_metrics.py

@@ -19,4 +19,4 @@ def test_set(self, rpush):
         os.environ["PRIVATE_IP"] = "127.0.0.1"
         metrics.set("my_metric", timestamp=1619629462352960742, test_i=2, test_fl=.3, test_t=True, test_f=False, test_s="gobble")
         rpush.assert_called_with(metrics.REDIS_METRICS_KEY,
-            'my_metric,dc=hetzner,server=127.0.0.1,project=listenbrainz.org test_i=2i,test_fl=0.3,test_t=t,test_f=f,test_s="gobble" 1619629462352960742')
+            'my_metric,dc=hetzner,server=127.0.0.1,project=listenbrainz.org test_i=2i,test_fl=0.300000,test_t=t,test_f=f,test_s="gobble" 1619629462352960742')