From 716f29a01003a1cb98bf212b13f130bbed640ae5 Mon Sep 17 00:00:00 2001 From: Misha Brukman Date: Tue, 27 Jan 2026 00:25:28 +0000 Subject: [PATCH] Rename utils.isLongTerm() -> is_long_term() Addresses lint warning to use snake_case instead of camelCase. --- utils.py | 2 +- utils_test.py | 6 +++--- vanguard.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/utils.py b/utils.py index 9dcb343..c848ad9 100644 --- a/utils.py +++ b/utils.py @@ -83,7 +83,7 @@ def txf_date(date: datetime) -> str: return date.strftime('%m/%d/%Y') -def isLongTerm(buy_date: datetime, sell_date: datetime) -> bool: +def is_long_term(buy_date: datetime, sell_date: datetime) -> bool: # To handle leap years, cannot use a standard number of days, i.e.: # sell_date - buy_date > timedelta(days=365) # - doesn't work for leap years diff --git a/utils_test.py b/utils_test.py index 5d9ed92..0b5d63d 100755 --- a/utils_test.py +++ b/utils_test.py @@ -25,18 +25,18 @@ class UtilsTest(unittest.TestCase): def testIsLongTermNonLeapYear(self): buy = datetime(2010, 1, 4) sell = datetime(2011, 1, 5) - self.assertTrue(utils.isLongTerm(buy, sell)) + self.assertTrue(utils.is_long_term(buy, sell)) def testIsLongTermLeapYear(self): buy = datetime(2008, 1, 4) sell = datetime(2009, 1, 4) - self.assertFalse(utils.isLongTerm(buy, sell)) + self.assertFalse(utils.is_long_term(buy, sell)) def testIsLongTermCorrectOrder(self): buy = datetime(2005, 1, 1) sell = datetime(2000, 1, 4) # TODO: verify error message. - self.assertRaises(utils.ValueError, utils.isLongTerm, buy, sell) + self.assertRaises(utils.ValueError, utils.is_long_term, buy, sell) if __name__ == '__main__': diff --git a/vanguard.py b/vanguard.py index ed5310c..4a9d3af 100644 --- a/vanguard.py +++ b/vanguard.py @@ -137,7 +137,7 @@ def parseFileToTxnList(cls, filename: str, tax_year: Optional[int]) -> list[util curr_txn.sellDateStr = utils.txf_date(sellDate) curr_txn.saleProceeds = cls.netAmount(sell) - if utils.isLongTerm(buyDate, sellDate): + if utils.is_long_term(buyDate, sellDate): curr_txn.entryCode = 323 # "LT gain/loss - security" else: curr_txn.entryCode = 321 # "ST gain/loss - security"