From 57417bcfee0e1a33b8c090e65ec33471a53572f8 Mon Sep 17 00:00:00 2001 From: martian56 Date: Sat, 25 Jul 2026 11:49:22 +0400 Subject: [PATCH] Drop a misbehaving paired baseline instead of failing the run The baseline server failed its setup statement on one profile and took the whole bench job with it. If either its server or its loadgen misbehaves the paired baseline is discarded and the report falls back to the cross run one. --- .github/workflows/bench.yml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 4738153..b36b62b 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -181,11 +181,19 @@ jobs: "$loadgen" --seconds 10 --connections 4 --rows 5000 --read-percent "$2" > pass.txt cat pass.txt python .github/scripts/parse_loadgen.py "$1" pass.txt >> "${{ matrix.profile }}.jsonl" + # A baseline that misbehaves drops out; the report falls back + # to the cross run one rather than failing the job. if [ -n "$BASE_SERVER" ]; then - "$BASE_LOADGEN" --seconds 10 --connections 4 --rows 5000 \ - --read-percent "$2" --address 127.0.0.1:54322 > base.txt - python .github/scripts/parse_loadgen.py "$1" base.txt \ - >> "base/${{ matrix.profile }}.jsonl" + if "$BASE_LOADGEN" --seconds 10 --connections 4 --rows 5000 \ + --read-percent "$2" --address 127.0.0.1:54322 > base.txt \ + && python .github/scripts/parse_loadgen.py "$1" base.txt \ + >> "base/${{ matrix.profile }}.jsonl"; then + : + else + echo "baseline pass failed; dropping the paired baseline" + rm -f "base/${{ matrix.profile }}.jsonl" + BASE_SERVER="" + fi fi done }