fix: resolve canonical repository coordinates

Author: mars167

server/src/models/Repository.ts

@@ -60,6 +60,18 @@ export class RepositoryModel {
     return result || null;
   }
 
+  findByPlatformFullName(
+    platform: Platform,
+    fullName: string
+  ): Repository | null {
+    const result = this.db.get<Repository>(
+      `SELECT * FROM repository
+       WHERE platform = ? AND full_name = ?`,
+      [platform, fullName]
+    );
+    return result || null;
+  }
+
   /**
    * 获取指定安装的所有仓库
    */
@@ -201,6 +213,9 @@ export class RepositoryModel {
         | 'webhook_url'
         | 'is_active'
         | 'remote_id'
+        | 'owner'
+        | 'name'
+        | 'full_name'
         | 'description'
         | 'is_private'
         | 'language'
@@ -237,6 +252,18 @@ export class RepositoryModel {
       fields.push('remote_id = ?');
       params.push(toNullableText(updates.remote_id));
     }
+    if (updates.owner !== undefined) {
+      fields.push('owner = ?');
+      params.push(updates.owner);
+    }
+    if (updates.name !== undefined) {
+      fields.push('name = ?');
+      params.push(updates.name);
+    }
+    if (updates.full_name !== undefined) {
+      fields.push('full_name = ?');
+      params.push(updates.full_name);
+    }
     if (updates.description !== undefined) {
       fields.push('description = ?');
       params.push(toNullableText(updates.description));
@@ -321,14 +348,18 @@ export class RepositoryModel {
   }
 
   upsert(dto: CreateRepositoryDTO): Repository {
-    const existing = this.findByPlatformOwnerName(dto.platform, dto.owner, dto.name);
+    const existing = this.findByPlatformOwnerName(dto.platform, dto.owner, dto.name)
+      || this.findByPlatformFullName(dto.platform, dto.full_name);
 
     if (!existing) {
       return this.create(dto);
     }
 
     const updated = this.update(existing.id, {
       remote_id: dto.remote_id,
+      owner: dto.owner,
+      name: dto.name,
+      full_name: dto.full_name,
       description: dto.description,
       is_private: dto.is_private ?? false,
       language: dto.language,

server/src/review/pullRequestSummaries.ts

@@ -1,4 +1,5 @@
 import type { Analysis, Job, ReviewReportSummary, JobPayload, Platform } from '../models/types';
+import { parseRepositoryFullName } from '../utils/repositoryCoordinates';
 import { normalizeApiTimestamp } from '../utils/time';
 
 export type ReviewRiskLevel = 'low' | 'medium' | 'high' | 'critical' | 'unknown';
@@ -80,23 +81,7 @@ export function buildPullRequestKey(target: PullRequestTarget): string {
   return `${buildRepositoryKey(target.platform, target.owner, target.repoName)}#${target.prNumber}`;
 }
 
-export function parseRepositoryFullName(
-  value: string | null | undefined
-): { owner: string; repoName: string } | null {
-  if (!value) {
-    return null;
-  }
-
-  const separatorIndex = value.indexOf('/');
-  if (separatorIndex <= 0 || separatorIndex >= value.length - 1) {
-    return null;
-  }
-
-  return {
-    owner: value.slice(0, separatorIndex),
-    repoName: value.slice(separatorIndex + 1),
-  };
-}
+export { parseRepositoryFullName } from '../utils/repositoryCoordinates';
 
 export function parseJsonObject(value: string | null | undefined): Record<string, unknown> | null {
   if (!value) {

server/src/routes/repositoryRoutes.test.ts

@@ -0,0 +1,151 @@
+import express from 'express';
+import request from 'supertest';
+
+const repositoryModelMock = {
+  findById: jest.fn(),
+  update: jest.fn(),
+};
+
+const oauthInstallationModelMock = {
+  findById: jest.fn(),
+};
+
+const oauthInstallationServiceMock = {
+  ensureValidAccessToken: jest.fn(),
+};
+
+const analysisModelMock = {
+  findByRepository: jest.fn(),
+};
+
+const analysisJobModelMock = {
+  findByAnalysisId: jest.fn(),
+};
+
+const jobModelMock = {
+  findByType: jest.fn(),
+};
+
+const queueServiceMock = {
+  getJobModel: jest.fn(() => jobModelMock),
+};
+
+const reviewTriggerServiceMock = {
+  triggerByRepositoryId: jest.fn(),
+};
+
+const platformClientMock = {
+  listPullRequests: jest.fn(),
+};
+
+const createPlatformClientMock = jest.fn(() => platformClientMock);
+
+jest.mock('../models/Repository', () => ({
+  getRepositoryModel: () => repositoryModelMock,
+}));
+
+jest.mock('../models/OAuthInstallation', () => ({
+  getOAuthInstallationModel: () => oauthInstallationModelMock,
+}));
+
+jest.mock('../models/Analysis', () => ({
+  getAnalysisModel: () => analysisModelMock,
+}));
+
+jest.mock('../models/AnalysisJob', () => ({
+  getAnalysisJobModel: () => analysisJobModelMock,
+}));
+
+jest.mock('../jobs/QueueService', () => ({
+  getQueueService: () => queueServiceMock,
+}));
+
+jest.mock('../platform/client', () => ({
+  createPlatformClient: createPlatformClientMock,
+}));
+
+jest.mock('../services/OAuthInstallationService', () => ({
+  getOAuthInstallationService: () => oauthInstallationServiceMock,
+}));
+
+jest.mock('../services/ReviewTriggerService', () => ({
+  getReviewTriggerService: () => reviewTriggerServiceMock,
+}));
+
+import repositoryRoutes from './repositoryRoutes';
+
+describe('repositoryRoutes', () => {
+  let app: express.Application;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    app = express();
+    app.use(express.json());
+    app.use('/', repositoryRoutes);
+
+    oauthInstallationModelMock.findById.mockReturnValue({
+      id: 3,
+      platform: 'gitee',
+      is_active: true,
+      access_token: 'token',
+      auth_type: 'oauth',
+    });
+    oauthInstallationServiceMock.ensureValidAccessToken.mockResolvedValue({
+      id: 3,
+      platform: 'gitee',
+      is_active: true,
+      access_token: 'token',
+      auth_type: 'oauth',
+    });
+    platformClientMock.listPullRequests.mockResolvedValue([]);
+    analysisModelMock.findByRepository.mockReturnValue([]);
+    analysisJobModelMock.findByAnalysisId.mockReturnValue([]);
+    jobModelMock.findByType.mockReturnValue([]);
+  });
+
+  it('uses canonical coordinates from full_name for pull request listing', async () => {
+    repositoryModelMock.findById.mockReturnValue({
+      id: 9163,
+      platform: 'gitee',
+      owner: 'mars167',
+      name: 'API REIVEW  PRO1',
+      full_name: 'api-review-test-group/api-reivew-pro1',
+      installation_id: 3,
+      is_active: true,
+    });
+    repositoryModelMock.update.mockReturnValue({
+      id: 9163,
+      platform: 'gitee',
+      owner: 'api-review-test-group',
+      name: 'api-reivew-pro1',
+      full_name: 'api-review-test-group/api-reivew-pro1',
+      installation_id: 3,
+      is_active: true,
+    });
+
+    const response = await request(app)
+      .get('/9163/pull-requests')
+      .query({ state: 'open', page: '1', limit: '20' });
+
+    expect(response.status).toBe(200);
+    expect(repositoryModelMock.update).toHaveBeenCalledWith(9163, {
+      owner: 'api-review-test-group',
+      name: 'api-reivew-pro1',
+      full_name: 'api-review-test-group/api-reivew-pro1',
+    });
+    expect(platformClientMock.listPullRequests).toHaveBeenCalledWith(
+      'api-review-test-group',
+      'api-reivew-pro1',
+      expect.objectContaining({
+        state: 'open',
+        page: 1,
+        per_page: 20,
+      })
+    );
+    expect(response.body.repository).toEqual(expect.objectContaining({
+      owner: 'api-review-test-group',
+      name: 'api-reivew-pro1',
+      full_name: 'api-review-test-group/api-reivew-pro1',
+    }));
+  });
+});