Added a fix for LocalAdmin not responding to commands after entering Idle Mode

Author: marchellcx

LabExtended/Core/ApiLoader.cs

@@ -51,6 +51,7 @@
 
 using Version = System.Version;
 using LabExtended.Patches.Events.Mirror;
+using Mirror;
 
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
 #pragma warning disable CS8764 // Nullability of return type doesn't match overridden member (possibly because of nullability attributes).
@@ -372,6 +373,7 @@ private static void InvokeApi(bool isPreload)
 
             Scp049CancellingResurrectionPatch.Internal_Init();
             MirrorSetSyncVarPatch.Internal_Init();
+            PrompterQueueIdleModeFix.Internal_Init();
 
             FirearmModuleCache.Internal_Init();
 

LabExtended/Events/MirrorEvents.cs

@@ -402,4 +402,7 @@ public static void OnSentRpc(NetworkBehaviour behaviour, string rpcName, int rpc
             ApiLog.Error("OnSentRpc", ex);
         }
     }
+
+    internal static bool Internal_AnySyncVarSubsribers()
+        => UpdatingSyncVar is not null || UpdatedSyncVar is not null;
 }

LabExtended/Patches/Events/Mirror/MirrorRemoveObserverPatch.cs

@@ -33,7 +33,7 @@ private static bool RemoveObserverPrefix(NetworkIdentity __instance, NetworkConn
         [HarmonyPatch(typeof(NetworkIdentity), nameof(NetworkIdentity.ClearObservers))]
         private static bool ClearObserversPrefix(NetworkIdentity __instance)
         {
-            foreach (var conn in __instance.observers.Values)
+            foreach (var conn in __instance.observers.Values.ToList())
             {
                 if (conn is null)
                     continue;

LabExtended/Patches/Events/Mirror/MirrorSetSyncVarPatch.cs

@@ -10,18 +10,22 @@
 
 using NorthwoodLib.Pools;
 
+using System.Reflection;
+
 namespace LabExtended.Patches.Events.Mirror
 {
     /// <summary>
     /// Implements the <see cref="MirrorEvents.UpdatingSyncVar"/> and <see cref="MirrorEvents.UpdatedSyncVar"/> events.
     /// </summary>
     public static class MirrorSetSyncVarPatch
     {
-        private static readonly HarmonyMethod patchMethod = new(
-            typeof(MirrorSetSyncVarPatch).FindMethod(x => x.Name == "GeneratedSyncVarSetterPrefix"));
+        private static readonly MethodInfo patchMethod = typeof(MirrorSetSyncVarPatch).FindMethod(x => x.Name == "GeneratedSyncVarSetterPrefix");
 
         private static bool GeneratedSyncVarSetterPrefix<T>(NetworkBehaviour __instance, T value, ref T field, ulong dirtyBit, Action<T, T> OnChanged)
         {
+            if (!MirrorEvents.Internal_AnySyncVarSubsribers())
+                return true;
+
             if (NetworkBehaviour.SyncVarEqual(value, ref field))
                 return false;
 
@@ -83,10 +87,11 @@ internal static void Internal_Init()
                                     continue;
 
                                 var genericMethod = targetMethod.MakeGenericMethod(property.PropertyType);
+                                var genericPatchMethod = patchMethod.MakeGenericMethod(property.PropertyType);
 
                                 if (genericMethod != null)
                                 {
-                                    if (ApiPatcher.Harmony.Patch(genericMethod, patchMethod) != null)
+                                    if (ApiPatcher.Harmony.Patch(genericMethod, new(genericPatchMethod)) != null)
                                     {
                                         patchedTypes.Add(property.PropertyType);
                                     }
@@ -113,7 +118,7 @@ internal static void Internal_Init()
                 ApiLog.Error("MirrorSetSyncVarPatch", ex);
             }
 
-            ApiLog.Debug("MirrorSetSyncVarPatch", $"Patched &3{patchedTypes.Count}&r SyncVar setters");
+            ApiLog.Debug("MirrorSetSyncVarPatch", $"Patched &3{patchedTypes.Count}&r SyncVar setter types");
 
             ListPool<Type>.Shared.Return(patchedTypes);
         }

LabExtended/Patches/Fixes/PrompterQueueIdleModeFix.cs

@@ -0,0 +1,34 @@
+using LabExtended.Core;
+using LabExtended.Utilities.Update;
+
+namespace LabExtended.Patches.Fixes
+{
+    /// <summary>
+    /// Fixes the issue with the prompter queue not being processed while in idle mode.
+    /// </summary>
+    public static class PrompterQueueIdleModeFix
+    {
+        private static void Internal_Update()
+        {
+            if (IdleMode.IdleModeActive)
+            {
+                while (ServerConsole.PrompterQueue.TryDequeue(out var command))
+                {
+                    try
+                    {
+                        ServerConsole.EnterCommand(command, ServerConsole.Scs);
+                    }
+                    catch (Exception ex)
+                    {
+                        ApiLog.Error(nameof(PrompterQueueIdleModeFix), ex);
+                    }
+                }
+            }
+        }
+
+        internal static void Internal_Init()
+        {
+            PlayerUpdateHelper.OnUpdate += Internal_Update;
+        }
+    }
+}