From 1bb4fa797870e7c79e7e72de4b05d5f5debcbb22 Mon Sep 17 00:00:00 2001 From: yurykanetski Date: Fri, 6 Jun 2025 13:50:06 +0200 Subject: [PATCH 1/2] ManeuverViewBinder: get rid of `TransitionManager#go` --- .../dropin/maneuver/ManeuverViewBinder.kt | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/maneuver/ManeuverViewBinder.kt b/libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/maneuver/ManeuverViewBinder.kt index c33226f40b3..88c92c06899 100644 --- a/libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/maneuver/ManeuverViewBinder.kt +++ b/libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/maneuver/ManeuverViewBinder.kt @@ -1,10 +1,8 @@ package com.mapbox.navigation.dropin.maneuver -import android.transition.Scene -import android.transition.TransitionManager +import android.view.LayoutInflater import android.view.ViewGroup import com.mapbox.navigation.core.lifecycle.MapboxNavigationObserver -import com.mapbox.navigation.dropin.R import com.mapbox.navigation.dropin.databinding.MapboxManeuverGuidanceLayoutBinding import com.mapbox.navigation.dropin.internal.extensions.reloadOnChange import com.mapbox.navigation.dropin.navigationview.NavigationViewContext @@ -18,13 +16,11 @@ internal class ManeuverViewBinder( ) : UIBinder { override fun bind(viewGroup: ViewGroup): MapboxNavigationObserver { - val scene = Scene.getSceneForLayout( - viewGroup, - R.layout.mapbox_maneuver_guidance_layout, - viewGroup.context + viewGroup.removeAllViews() + val binding = MapboxManeuverGuidanceLayoutBinding.inflate( + LayoutInflater.from(viewGroup.context), + viewGroup ) - TransitionManager.go(scene) - val binding = MapboxManeuverGuidanceLayoutBinding.bind(viewGroup) return reloadOnChange( context.mapStyleLoader.loadedMapStyle, From 555d65597d5085a43384312c3d680f49e1aed708 Mon Sep 17 00:00:00 2001 From: yurykanetski Date: Fri, 11 Jul 2025 14:02:25 +0200 Subject: [PATCH 2/2] changelog --- changelog/unreleased/bugfixes/7908.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog/unreleased/bugfixes/7908.md diff --git a/changelog/unreleased/bugfixes/7908.md b/changelog/unreleased/bugfixes/7908.md new file mode 100644 index 00000000000..8bcd55f148b --- /dev/null +++ b/changelog/unreleased/bugfixes/7908.md @@ -0,0 +1 @@ +- Fixed crash on `ManeuverViewBinder` with TransitionManager#go(Scene). \ No newline at end of file