[Documentation] ASN.1 Boolean mismatch

[F9Alejandro]

In the documentation on your confluence site it says that booleans should return 0xFF for a true state and 0x00 for a false state. While looking at the code (trying to debug scp issues giving 6982 errors) it seems that for the ternary responses instead of returning 0xFF for true it is returning 1 or 0x01 for true instead. Should this be updated in the documentation to reflect the code? or should this be unified across the code base for 0xFF to be boolean true and 0x00 boolean false?

Thought this may help out others that run into odd issues with getStatus command and such.

[makinako]

Hi @F9Alejandro firstly apologies for the delay on replying to this:

You are right that all BOOLEAN ASN.1 responses should be FF. I'm looking at the getStatus code (below) and a first glance seems that the ternary conditions are all returning the constant? Do you remember which field was returning the wrong value?

private short processGetStatus(TLVWriter writer) {

    final byte CONST_TAG_APPLET_STATE = (byte) 0x80;
    final byte CONST_TAG_OP_ROLE = (byte) 0x81;
    final byte CONST_TAG_OP_ID = (byte) 0x82;
    final byte CONST_TAG_OP_IMMEDIATE = (byte) 0x83;
    final byte CONST_TAG_SM_STATE = (byte) 0x84;
    final byte CONST_TAG_VCI_STATE = (byte) 0x85;
    final byte CONST_TAG_CONTACTLESS = (byte) 0x86;
    final byte CONST_TAG_FIPS_MODE = (byte) 0x87;

    // We don't check the operator integrity here since it serves to security function

    // Applet State
    writer.write(CONST_TAG_APPLET_STATE, GPSystem.getCardContentState());

    // PIN Verified
    writer.write(CONST_TAG_OP_ROLE, operator.getRoles());

    // PIN Verified
    writer.write(CONST_TAG_OP_ID, operator.getId());

    // PIN Always
    writer.write(CONST_TAG_OP_IMMEDIATE, operator.getImmediateFlag(false) ? TLV.TRUE : TLV.FALSE);

    // SM & VCI State
    // NOTE: This does NOT indicate whether the current command is PIV-SM wrapped, or VCI.
    // Instead it just indicates if these are established and therefore CAN be used.
    if (channelPIVSM.isEstablished()) {
      PIVVerifier pc = dataStore.getVerifier(Constants.ID_AUTH_PAIRING_CODE);
      boolean vci = (pc == null || pc.isValidated());

      writer.write(CONST_TAG_SM_STATE, TLV.TRUE);
      writer.write(CONST_TAG_VCI_STATE, vci ? TLV.TRUE : TLV.FALSE);
    } else {
      writer.write(CONST_TAG_SM_STATE, TLV.FALSE);
      writer.write(CONST_TAG_VCI_STATE, TLV.FALSE);
    }

    // Contactless
    writer.write(CONST_TAG_CONTACTLESS, Platform.isContactless() ? TLV.TRUE : TLV.FALSE);

    // FIPS Mode
    writer.write(CONST_TAG_FIPS_MODE, Config.FIPS_APPROVED_MODE ? TLV.TRUE : TLV.FALSE);

    return writer.finish();
  }