Skip to content

Commit a2e2ffd

Browse files
committed
parameterized map controller and web engine fields. added new layer event. added deprecated javadocs
1 parent 8d327a6 commit a2e2ffd

6 files changed

Lines changed: 14 additions & 12 deletions

File tree

jlmap-api/src/main/java/io/github/makbn/jlmap/JLMapController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ default void checkMapState() {
127127
}
128128
}
129129

130-
private @Nullable <T extends LeafletLayer> T getLayerInternal(@NonNull Class<T> layerClass) {
130+
private @Nullable <M extends LeafletLayer> M getLayerInternal(@NonNull Class<M> layerClass) {
131131
return getLayers().entrySet()
132132
.stream()
133133
.filter(entry -> layerClass.isAssignableFrom(entry.getKey()))

jlmap-api/src/main/java/io/github/makbn/jlmap/listener/OnJLObjectActionListener.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,27 @@
1010
*/
1111
public interface OnJLObjectActionListener<T extends JLObject<?>> extends OnJLActionListener<T> {
1212

13+
/**
14+
* try to override and use {@link #onAction(JLObject, Event)}
15+
* @deprecated this method will be removed with the next minor version
16+
*/
1317
@Deprecated(forRemoval = true)
1418
default void click(T t, JLAction action) {
1519
// NO-OP
1620
}
1721

22+
/**
23+
* try to override and use {@link #onAction(JLObject, Event)}
24+
* @deprecated this method will be removed with the next minor version
25+
*/
1826
@Deprecated(forRemoval = true)
1927
default void move(T t, JLAction action) {
2028
// NO-OP
2129
}
2230

2331
/**
2432
* try to override and use {@link #onAction(JLObject, Event)}
33+
* @deprecated this method added for the transition period and will be removed with the next minor version
2534
*/
2635
@Deprecated(forRemoval = true)
2736
void onActionReceived(T t, Event event);

jlmap-fx/src/main/java/io/github/makbn/jlmap/fx/demo/LeafletTestJFX.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,7 @@ public void onActionReceived(Event event) {
128128
}
129129

130130
private OnJLObjectActionListener<JLMarker> getListener() {
131-
return new OnJLObjectActionListener<>() {
132-
@Override
133-
public void onActionReceived(JLMarker jlMarker, Event event) {
134-
log.info("object {} event for marker:{}", event.action(), jlMarker);
135-
}
136-
};
131+
return (jlMarker, event) -> log.info("object {} event for marker:{}", event.action(), jlMarker);
137132
}
138133

139134
private void addMultiPolyline(JLMapView map) {

jlmap-vaadin/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
</plugin>
6161
</plugins>
6262
<sourceDirectory>src/main/java</sourceDirectory>
63-
<!--<testSourceDirectory>src/test/java</testSourceDirectory>-->
6463
</build>
6564

6665
<dependencyManagement>

jlmap-vaadin/src/main/java/io/github/makbn/jlmap/vaadin/layer/JLVaadinGeoJsonLayer.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
*/
2323
@FieldDefaults(level = AccessLevel.PRIVATE, makeFinal = true)
2424
public class JLVaadinGeoJsonLayer extends JLVaadinLayer implements LeafletGeoJsonLayerInt {
25-
private static final String MEMBER_PREFIX = "geoJson";
26-
2725
JLGeoJsonURL fromUrl;
2826
JLGeoJsonFile fromFile;
2927
JLGeoJsonContent fromContent;

jlmap-vaadin/src/main/java/io/github/makbn/jlmap/vaadin/layer/JLVaadinLayer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.github.makbn.jlmap.vaadin.layer;
22

3+
import com.vaadin.flow.component.page.PendingJavaScriptResult;
34
import io.github.makbn.jlmap.JLMapCallbackHandler;
45
import io.github.makbn.jlmap.engine.JLWebEngine;
56
import io.github.makbn.jlmap.layer.leaflet.LeafletLayer;
@@ -19,11 +20,11 @@
1920

2021
@FieldDefaults(level = AccessLevel.PROTECTED, makeFinal = true)
2122
public abstract class JLVaadinLayer implements LeafletLayer {
22-
JLWebEngine engine;
23+
JLWebEngine<PendingJavaScriptResult> engine;
2324
JLMapCallbackHandler callbackHandler;
2425
String componentSessionId = "_" + UUID.randomUUID().toString().replace("-", "") + "_";
2526

26-
protected JLVaadinLayer(JLWebEngine engine, JLMapCallbackHandler callbackHandler) {
27+
protected JLVaadinLayer(JLWebEngine<PendingJavaScriptResult> engine, JLMapCallbackHandler callbackHandler) {
2728
this.engine = engine;
2829
this.callbackHandler = callbackHandler;
2930
}

0 commit comments

Comments
 (0)