Skip to content

inplaceEditor Key Event Handlers #21

@gregorytmorgan

Description

@gregorytmorgan

v1.8.3

Not sure the key event handling is right. registerListeners() assigns the key listeners to the target container, not the form input element. See my patch below.

  • Add assignment of onkeydown event handler to form INPUT in createEditField().

    line: ~505 - this._keyHandler = this.checkForEscapeOrReturn.bind(this);

  • Prevent blur event caused by escape from triggering a submit

    line: ~512 - if (Event.KEY_ESC == e.keyCode) { this.handleFormCancellation(e); }



    line: ~555 - Event.observe(fld, 'keydown', this._keyHandler);

  • Remove key event handlers from target container handlers.

    line: ~932 - REMOVE THIS LINE ALTOGETHER - "keydown: 'checkForEscapeOrReturn',

-G

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions