fix: Re-sync selected configuration on edit and honor the hash contract

Editing a configuration mutates it in place, but the selected
configuration is persisted as a separate decoded snapshot, so after
editing the selected row the extension kept formatting with the old URLs
until the user re-selected it. Capture whether the edited row is the
current selection before presenting the sheet and, on save, re-write the
selected configuration with the edited value.

Override hash to combine the same fields equality uses (name,
swiftFormat, uncrustify), satisfying the NSObject equal-implies-equal-hash
contract, and remove the dead isEqual(to:) forwarder.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: macmade

Shared/Configuration.swift

@@ -57,11 +57,6 @@ public class Configuration: NSObject, Codable
         "\( super.description ): \( self.name )"
     }
 
-    public override func isEqual( to object: Any? ) -> Bool
-    {
-        self.isEqual( object )
-    }
-
     public override func isEqual( _ object: Any? ) -> Bool
     {
         guard let configuration = object as? Configuration
@@ -80,6 +75,17 @@ public class Configuration: NSObject, Codable
         return false
     }
 
+    public override var hash: Int
+    {
+        var hasher = Hasher()
+
+        hasher.combine( self.name )
+        hasher.combine( self.swiftFormat )
+        hasher.combine( self.uncrustify )
+
+        return hasher.finalize()
+    }
+
     public func download()
     {
         DispatchQueue.main.async

SharedTests/ConfigurationTests.swift

@@ -104,4 +104,36 @@ struct ConfigurationTests
         #expect( configuration.isEqual( "X" ) == false )
         #expect( configuration.isEqual( nil ) == false )
     }
+
+    @Test( "Equal configurations produce equal hashes" )
+    func equalConfigurationsHaveEqualHashes()
+    {
+        let lhs = Configuration( name: "X", swiftFormat: URL( string: "https://a" ), uncrustify: URL( string: "https://b" ) )
+        let rhs = Configuration( name: "X", swiftFormat: URL( string: "https://a" ), uncrustify: URL( string: "https://b" ) )
+
+        #expect( lhs == rhs )
+        #expect( lhs.hash == rhs.hash )
+        #expect( lhs.hashValue == rhs.hashValue )
+    }
+
+    @Test( "Equal configurations coalesce in a Set" )
+    func equalConfigurationsCoalesceInASet()
+    {
+        let lhs = Configuration( name: "X", swiftFormat: URL( string: "https://a" ), uncrustify: URL( string: "https://b" ) )
+        let rhs = Configuration( name: "X", swiftFormat: URL( string: "https://a" ), uncrustify: URL( string: "https://b" ) )
+
+        let set: Set< Configuration > = [ lhs, rhs ]
+
+        #expect( set.count == 1 )
+    }
+
+    @Test( "Equal configurations with nil URLs produce equal hashes" )
+    func equalConfigurationsWithNilURLsHaveEqualHashes()
+    {
+        let lhs = Configuration( name: "Empty", swiftFormat: nil, uncrustify: nil )
+        let rhs = Configuration( name: "Empty", swiftFormat: nil, uncrustify: nil )
+
+        #expect( lhs == rhs )
+        #expect( lhs.hash == rhs.hash )
+    }
 }

XcodeFormat/Classes/ConfigurationsWindowController.swift

@@ -127,6 +127,11 @@ public class ConfigurationsWindowController: NSWindowController
             return
         }
 
+        // Capture whether this row is the persisted selection *before* the sheet
+        // edits the object in place. selectedConfiguration is a separate decoded
+        // snapshot, so without re-syncing it would keep the pre-edit URLs.
+        let wasSelected = Preferences.shared.selectedConfiguration.map { configuration.isEqual( $0 ) } ?? false
+
         controller.configuration           = configuration
         self.configurationWindowController = controller
 
@@ -135,6 +140,11 @@ public class ConfigurationsWindowController: NSWindowController
             if $0 == .OK
             {
                 Preferences.shared.configurations = self.arrayController.content as? [ Configuration ] ?? []
+
+                if wasSelected
+                {
+                    Preferences.shared.selectedConfiguration = configuration
+                }
             }
         }
     }