I noticed this when creating a new fault/alert (overcurrent) for our HSD. Currently the new CAN message created runs at 10Hz as well, so I wanted to bring up if alerts should be sent at a higher rate or if they should be left as is. More importantly I think from a semantic point of view, I disagree with IMD, and BMS faults being stored as: BO_ 211 LvStatus: 4 LVC. Especially if they're being packed alongside info like LvState, Counter, and MotorControllerState I think moving forwards, we should port these over to LvAlerts instead...
I noticed this when creating a new fault/alert (overcurrent) for our HSD. Currently the new CAN message created runs at 10Hz as well, so I wanted to bring up if alerts should be sent at a higher rate or if they should be left as is. More importantly I think from a semantic point of view, I disagree with IMD, and BMS faults being stored as:
BO_ 211 LvStatus: 4 LVC. Especially if they're being packed alongside info likeLvState, Counter, and MotorControllerStateI think moving forwards, we should port these over toLvAlertsinstead...