From abf67063670f281eecd482dd0e4aff3ce22739eb Mon Sep 17 00:00:00 2001 From: Stella Test Date: Thu, 6 Aug 2026 04:06:17 -0700 Subject: [PATCH] =?UTF-8?q?fix(main):=20unbreak=20three=20gates=20the=20#1?= =?UTF-8?q?813=20auto-merge=20and=20#1828=20left=20red=20=E2=80=94=20clipp?= =?UTF-8?q?y=20clone-on-Copy,=20two=20file-size=20overruns?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #1813 merged its pre-rebase head while its fmt+clippy+test job was still running, landing a clippy::clone_on_copy on GenerationParams in apply_role_shaping and a StageKind::Witness doc comment that put event.rs 2 lines over its god-file ceiling (the wire schema is regenerated for the reworded comment). #1828 separately grew deck_render.rs 3 lines past its ceiling; Stopped joins Cancelled's match arm — same theme value, and the grouping states what the comment said. Verified: check-file-size green, check-wire-schema green, clippy -D warnings green on stella-pipeline, cargo test -p stella-tui green. --- .../src/pipeline/witness_stage.rs | 4 ++-- crates/stella-protocol/src/event.rs | 16 +++++++--------- crates/stella-tui/src/deck_render.rs | 5 +---- docs/wire/agentevent.schema.json | 2 +- docs/wire/serveframe.schema.json | 2 +- 5 files changed, 12 insertions(+), 17 deletions(-) diff --git a/crates/stella-pipeline/src/pipeline/witness_stage.rs b/crates/stella-pipeline/src/pipeline/witness_stage.rs index f1b7a8b80..c1d008f83 100644 --- a/crates/stella-pipeline/src/pipeline/witness_stage.rs +++ b/crates/stella-pipeline/src/pipeline/witness_stage.rs @@ -51,8 +51,8 @@ fn apply_role_shaping(mut config: EngineConfig, overrides: &RoleCallOverrides) - if let Some(max_output_tokens) = overrides.max_output_tokens { config.max_output_tokens = Some(max_output_tokens); } - if let Some(params) = &overrides.params { - config.params = Some(params.clone()); + if let Some(params) = overrides.params { + config.params = Some(params); } config } diff --git a/crates/stella-protocol/src/event.rs b/crates/stella-protocol/src/event.rs index 1dc72aad6..bc2d7f9b1 100644 --- a/crates/stella-protocol/src/event.rs +++ b/crates/stella-protocol/src/event.rs @@ -113,15 +113,13 @@ pub enum StageKind { Plan, /// The interactive approval gate a large plan passes through (L-E5). ScopeReview, - /// Witness authoring: after the worker executes — once the warrant has - /// read the diff and found something worth proving — an independent - /// model (the verifier's resolution, never the worker's transcript) - /// writes the witness test in a pristine snapshot of the pre-execution - /// tree: a test that FAILS there and will pass once the goal is met, - /// arming the deterministic flip oracle (L-E11). The witness is visible - /// to the worker's revise turns (iterating against a failing test is - /// where convergence comes from); integrity comes from tamper exclusion - /// at verify time, not from hiding the test. + /// Witness authoring: after the worker executes, once the warrant has + /// read the diff, an independent model (the verifier's resolution, never + /// the worker's transcript) writes the witness test in a pristine + /// snapshot of the pre-execution tree — a test that FAILS there and will + /// pass once the goal is met, arming the flip oracle (L-E11). Visible to + /// the worker's revise turns; integrity comes from tamper exclusion at + /// verify time, not from hiding the test. Witness, /// The worker's own tool-calling loop — the steps that actually change /// the workspace. diff --git a/crates/stella-tui/src/deck_render.rs b/crates/stella-tui/src/deck_render.rs index 9440668a3..2cb5557a9 100644 --- a/crates/stella-tui/src/deck_render.rs +++ b/crates/stella-tui/src/deck_render.rs @@ -453,10 +453,7 @@ fn phase_color(phase: crate::envelope::SessionPhase) -> ratatui::style::Color { SessionPhase::InProgress => theme::SUCCESS_BRIGHT, SessionPhase::NeedsInput => theme::WARNING_BRIGHT, SessionPhase::Paused => theme::ACCENT, - SessionPhase::Cancelled => theme::TEXT_TERTIARY, - // The same calm tone as `Cancelled`: both are deliberate endings, - // and the whole point of the variant is not to paint them red. - SessionPhase::Stopped => theme::TEXT_TERTIARY, + SessionPhase::Cancelled | SessionPhase::Stopped => theme::TEXT_TERTIARY, SessionPhase::Complete => theme::SUCCESS, SessionPhase::Archived => theme::TEXT_TERTIARY, SessionPhase::Error => theme::DANGER_BRIGHT, diff --git a/docs/wire/agentevent.schema.json b/docs/wire/agentevent.schema.json index 675c29b7a..be9801a9a 100644 --- a/docs/wire/agentevent.schema.json +++ b/docs/wire/agentevent.schema.json @@ -1281,7 +1281,7 @@ }, { "const": "witness", - "description": "Witness authoring: after the worker executes — once the warrant has\nread the diff and found something worth proving — an independent\nmodel (the verifier's resolution, never the worker's transcript)\nwrites the witness test in a pristine snapshot of the pre-execution\ntree: a test that FAILS there and will pass once the goal is met,\narming the deterministic flip oracle (L-E11). The witness is visible\nto the worker's revise turns (iterating against a failing test is\nwhere convergence comes from); integrity comes from tamper exclusion\nat verify time, not from hiding the test.", + "description": "Witness authoring: after the worker executes, once the warrant has\nread the diff, an independent model (the verifier's resolution, never\nthe worker's transcript) writes the witness test in a pristine\nsnapshot of the pre-execution tree — a test that FAILS there and will\npass once the goal is met, arming the flip oracle (L-E11). Visible to\nthe worker's revise turns; integrity comes from tamper exclusion at\nverify time, not from hiding the test.", "type": "string" }, { diff --git a/docs/wire/serveframe.schema.json b/docs/wire/serveframe.schema.json index 6b72cd05a..d475e6e12 100644 --- a/docs/wire/serveframe.schema.json +++ b/docs/wire/serveframe.schema.json @@ -2882,7 +2882,7 @@ }, { "const": "witness", - "description": "Witness authoring: after the worker executes — once the warrant has\nread the diff and found something worth proving — an independent\nmodel (the verifier's resolution, never the worker's transcript)\nwrites the witness test in a pristine snapshot of the pre-execution\ntree: a test that FAILS there and will pass once the goal is met,\narming the deterministic flip oracle (L-E11). The witness is visible\nto the worker's revise turns (iterating against a failing test is\nwhere convergence comes from); integrity comes from tamper exclusion\nat verify time, not from hiding the test.", + "description": "Witness authoring: after the worker executes, once the warrant has\nread the diff, an independent model (the verifier's resolution, never\nthe worker's transcript) writes the witness test in a pristine\nsnapshot of the pre-execution tree — a test that FAILS there and will\npass once the goal is met, arming the flip oracle (L-E11). Visible to\nthe worker's revise turns; integrity comes from tamper exclusion at\nverify time, not from hiding the test.", "type": "string" }, {