From 868443423bb9bbb8b6881e92fd2460e0e097aa6f Mon Sep 17 00:00:00 2001 From: Stella Test Date: Thu, 6 Aug 2026 04:06:03 -0700 Subject: [PATCH 1/2] =?UTF-8?q?fix(stella-pipeline):=20unbreak=20clippy=20?= =?UTF-8?q?=E2=80=94=20deref=20the=20Copy=20GenerationParams=20instead=20o?= =?UTF-8?q?f=20cloning=20it?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `clippy::clone_on_copy` fails the workspace at -D warnings on main: `apply_role_shaping` in witness_stage.rs clones `GenerationParams`, which is `Copy`. One-word fix, exactly clippy's suggestion. Landed red because the introducing PR merged without a green gate (enforce_admins is off); every open PR inherits the failure until this lands. --- crates/stella-pipeline/src/pipeline/witness_stage.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/stella-pipeline/src/pipeline/witness_stage.rs b/crates/stella-pipeline/src/pipeline/witness_stage.rs index f1b7a8b80..d3242d866 100644 --- a/crates/stella-pipeline/src/pipeline/witness_stage.rs +++ b/crates/stella-pipeline/src/pipeline/witness_stage.rs @@ -52,7 +52,7 @@ fn apply_role_shaping(mut config: EngineConfig, overrides: &RoleCallOverrides) - config.max_output_tokens = Some(max_output_tokens); } if let Some(params) = &overrides.params { - config.params = Some(params.clone()); + config.params = Some(*params); } config } From 7b82aff4317eeaddce3900e58f8c68b3b374a936 Mon Sep 17 00:00:00 2001 From: Stella Test Date: Thu, 6 Aug 2026 04:11:22 -0700 Subject: [PATCH 2/2] fix(gate): re-true the file-size baseline and the gate's spelled step count Two more pre-existing gate failures on main, found by running guards-fast at its tip: - file-size: crates/stella-protocol/src/event.rs (+2) and crates/stella-tui/src/deck_render.rs (+3) grew past their recorded ceilings via already-merged PRs. Regenerated with `make file-size-update`, which also RETIGHTENS command_deck.rs (4740->4691), fleet_cmd.rs (1507->1504) and pipeline.rs (3642->3580) to their shrunken sizes. - gate-parity: GATE_STEPS runs 25 steps, but AGENTS.md/CONTRIBUTING.md still spelled "twenty-four" (the step lists themselves were current). --- AGENTS.md | 2 +- CONTRIBUTING.md | 2 +- scripts/file-size-baseline.txt | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index cc171a764..d324ea1e3 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -73,7 +73,7 @@ make gate # = no-scratch + no-secrets + design-refs # + self-driving-test (the shell harness) ``` -That is twenty-four steps, and the list is not maintained by hand: it is +That is twenty-five steps, and the list is not maintained by hand: it is `GATE_STEPS` in the `Makefile`, and `gate-parity` (`scripts/check-gate-parity.sh`) fails if this block or CONTRIBUTING.md's stops matching it. The block had already drifted twice before that guard existed, both times by under-reporting diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c9ed700cd..1403e2f14 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -95,7 +95,7 @@ cargo build -p stella-cli --bin stella && \ STELLA_BIN="$PWD/target/debug/stella" ./scripts/test-self-driving.sh ``` -Or just `make gate`, which is the twenty-four of them in order. +Or just `make gate`, which is the twenty-five of them in order. Do not maintain that list by hand. It is `GATE_STEPS` in the `Makefile`, and `./scripts/check-gate-parity.sh` — itself one of the steps — fails if this fence diff --git a/scripts/file-size-baseline.txt b/scripts/file-size-baseline.txt index b030d2807..5aecd16c3 100644 --- a/scripts/file-size-baseline.txt +++ b/scripts/file-size-baseline.txt @@ -17,8 +17,8 @@ 1659 bench/terminal_bench_analysis/tests/test_tb21_evidence_contract.py 2269 crates/stella-cli/src/agent.rs 1751 crates/stella-cli/src/agent/tests.rs -4740 crates/stella-cli/src/command_deck.rs -1507 crates/stella-cli/src/fleet_cmd.rs +4691 crates/stella-cli/src/command_deck.rs +1504 crates/stella-cli/src/fleet_cmd.rs 2129 crates/stella-core/src/bus.rs 2580 crates/stella-core/src/driver.rs 3680 crates/stella-core/src/driver/tests.rs @@ -26,16 +26,16 @@ 2093 crates/stella-model/src/openai.rs 1565 crates/stella-model/src/zai.rs 1895 crates/stella-model/src/zai/tests.rs -3642 crates/stella-pipeline/src/pipeline.rs +3580 crates/stella-pipeline/src/pipeline.rs 2568 crates/stella-pipeline/src/pipeline/tests.rs -2962 crates/stella-protocol/src/event.rs +2964 crates/stella-protocol/src/event.rs 1995 crates/stella-store/src/lib.rs 2268 crates/stella-store/src/tests.rs 1916 crates/stella-store/src/usage.rs 1569 crates/stella-tools/src/media.rs 2184 crates/stella-tools/src/registry.rs 1839 crates/stella-tools/src/scripts.rs -1528 crates/stella-tui/src/deck_render.rs +1531 crates/stella-tui/src/deck_render.rs 4006 crates/stella-tui/src/deck_ui.rs 1665 crates/stella-tui/src/views/engine.rs 1611 crates/stella-tui/src/views/session.rs