From 84ea11ecb5288b86e3128960cd4e2439bba9c4f1 Mon Sep 17 00:00:00 2001 From: Stella Test Date: Thu, 6 Aug 2026 03:55:51 -0700 Subject: [PATCH] =?UTF-8?q?fix(stella-pipeline):=20unbreak=20main=20?= =?UTF-8?q?=E2=80=94=20clippy=20failures=20merged=20in=20#1813's=20witness?= =?UTF-8?q?=20stage?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 608a0aa5 (#1813) landed two clippy -D warnings failures in pipeline/witness_stage.rs, red on main and on every PR branched from it (the first masks the second because cargo bails at the first error): - clone_on_copy: `params.clone()` where GenerationParams became `Copy` in a parallel change — copy it out of the borrow instead. - field_reassign_with_default: the #1785 witness test built its worker config by mutating a `default()` — use struct-update syntax. --- .../stella-pipeline/src/pipeline/witness_stage.rs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/crates/stella-pipeline/src/pipeline/witness_stage.rs b/crates/stella-pipeline/src/pipeline/witness_stage.rs index f1b7a8b80..6df2a9ea9 100644 --- a/crates/stella-pipeline/src/pipeline/witness_stage.rs +++ b/crates/stella-pipeline/src/pipeline/witness_stage.rs @@ -51,8 +51,8 @@ fn apply_role_shaping(mut config: EngineConfig, overrides: &RoleCallOverrides) - if let Some(max_output_tokens) = overrides.max_output_tokens { config.max_output_tokens = Some(max_output_tokens); } - if let Some(params) = &overrides.params { - config.params = Some(params.clone()); + if let Some(params) = overrides.params { + config.params = Some(params); } config } @@ -645,10 +645,12 @@ mod tests { /// `EngineConfig` knob — the type system keeps it raw-call-scoped). #[test] fn verifier_shaping_overlays_the_worker_engine_config() { - let mut worker = EngineConfig::default(); - worker.temperature = Some(0.7); - worker.max_output_tokens = Some(1000); - worker.effort = None; + let worker = EngineConfig { + temperature: Some(0.7), + max_output_tokens: Some(1000), + effort: None, + ..EngineConfig::default() + }; let shaped = apply_role_shaping( worker.clone(),