Warnings to silence

[stefonarch]

libfm-qt-git/src/libfm-qt/src/mountoperation.cpp:174:64:
/tmp/makepkg/libfm-qt-git/src/libfm-qt/src/mountoperationquestiondialog.cpp:35:53: warning: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
   35 |     choiceButtons = new QAbstractButton*[choiceCount];
      |                                                     ^
/usr/include/c++/15.2.1/new: In function ‘onAskQuestion’:
/usr/include/c++/15.2.1/new:140:26: note: in a call to allocation function ‘operator new []’ declared here
  140 | _GLIBCXX_NODISCARD void* operator new[](std::size_t)

libfm-qt/src/proxyfoldermodel.cpp:91:25: warning: ‘void QSortFilterProxyModel::invalidateFilter()’ is deprecated: Use begin/endFilterChange() instead [-Wdeprecated-declarations]
   91 |         invalidateFilter();
      |         ~~~~~~~~~~~~~~~~^~

libfm-qt/src/core/vfs/vfs-search.c:462:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  462 |         char* params = strchr(p, '?');
      |                        ^~~~~~
/tmp/makepkg/libfm-qt-git/src/libfm-qt/src/core/vfs/vfs-search.c:469:25: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  469 |             char* sep = strchr(p, ','); /* use , to separate multiple paths */

[isf63]

For char* <foo> = strchr(...); you want to add or discard const depending on the logic. Also in another PR I saw.

18446744073709551615 equals -1 for unsigned in some word size (I think 64-bit). I'm not sure there, would seem to waste some memory if it was incorrect.

invalidateFilter says use begin/endFilterChange() which requires Qt refactoring.

[stefonarch]

invalidateFilter says use begin/endFilterChange() which requires Qt refactoring.

This should be easy, we did it already somewhere.

diff --git a/src/placesview.cpp b/src/placesview.cpp
index cc220e7..e80eb76 100644
--- a/src/placesview.cpp
+++ b/src/placesview.cpp
@@ -59,7 +59,8 @@ void PlacesProxyModel::restoreHiddenItems(const QSet<QString>& items) {
             ++i;
         }
         hiddenItemsRestored_ = true;
-        invalidateFilter();
+        beginFilterChange();
+        endFilterChange();
     }
 }

[isf63]

If cmake -DCMAKE_CXX_FLAGS="-Wpedantic -Wall" .. is correct, the only remaining warnings are for invalidateFilter();, after #1104.