Skip to content

Could you add a LICENSE file? (README says "Apache" but not which version) #140

Description

@JRM-IT

Hi Lucas,

Thanks for Kokoros! I am using it in a desktop application, and it's been a pleasure to work with.

One small thing I'd like to get right on my side. The README says:

Copyright reserved by Lucas Jin under Apache License.

but the repository has no LICENSE file and no license field in the manifests, so the Apache version isn't stated anywhere. Since I'm shipping in a commercial product I'd rather rely on an explicit statement than on my own reading of that line; and anyone else evaluating Kokoros for production use will hit exactly the same question.

If Apache-2.0 is what you intended, GitHub can add it in one click:

https://github.com/lucasjinreal/Kokoros/community/license/new?branch=main&template=apache-2.0

That opens the license picker with Apache-2.0 pre-filled and commits a standard LICENSE at the repo root. Adding license = "Apache-2.0" to Cargo.toml would also let cargo tooling pick it up automatically.

For completeness, here's how I'm attributing your work. Happy to adjust the wording if you'd prefer it phrased differently:

This product includes software developed as part of the Kokoros project
(https://github.com/lucasjinreal/Kokoros), copyright reserved by Lucas Jin, licensed under the
Apache License, Version 2.0.

Files taken from Kokoros have been changed.

Thanks again!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions