Skip to content

Missing OpenTelemetry span in pusher Kick case (memory leak) #225

Description

@lstep

Bug

In backend/internal/pusher/pusher.go, the ClientFrame_Kick case creates no OpenTelemetry span, unlike all other frame cases (SetStatus, SetAfk, Recording, etc. which all call s.tracer.Start and pspan.End()).

Impact

The kick publish is untraced, and since there's no span at all, there's no pspan.End() call. This is inconsistent with every other frame handler and means kick operations are invisible in traces.

Fix

Add a pusher.nats.publish.kick span with attributes, use pctx for otel injection, record errors on publish failure, and call pspan.End() — matching the pattern of all other frame cases.

PR

#226

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions