Validation freeze for many seconds

[fdbva]

I'm in process of moving from <PackageReference Include="Blazored.FluentValidation" Version="2.2.0" /> to <PackageReference Include="Blazilla" Version="2.2.2" />.

On my page, I've made these changes:

        <EditForm @ref="EditForm" Model="@Parent" @onsubmit:preventDefault>
            <FluentValidationValidator @ref="FluentValidationValidator" />

to

        <EditForm @ref="EditForm" Model="@Parent" @onsubmit:preventDefault>
        <FluentValidator />

and

    private Task<bool> ValidateAsync()
    {
        var validationResult = FluentValidationValidator!.Validate();
...

to

    private Task<bool> ValidateAsync()
    {
        var validationResult = EditForm.EditContext!.Validate();
...

My page is complex, but the validation rules are simple.

These are my validators:

public class ParentValidator : AbstractValidator<ParentEntity>
{
    public ParentValidator (IValidator<TestEntity> child1Validator)
    {
        ...
        RuleForEach(x => x.Children).SetValidator(child1Validator);
    }
}
public class Child1Validator : AbstractValidator<Child1Entity>
{
    public Child1Validator(IValidator<Child2Entity> child2Validator)
    {
        ...
        RuleForEach(x => x.Children)
            .SetValidator(child2Validator);
    }
}
public class Child2Validator : AbstractValidator<Child2Entity>
{
    public Child2Validator ()
    {
        RuleLevelCascadeMode = CascadeMode.Stop;
        ...
    }
}

When I try to check on DotTrace to see what's happening:

And if I comment out or revert back to Blazored, everything works again.

Ah, I need to point out that the Parent starts with 0 Childs.
Everything freezes when I click to add one new Child and it hangs for 50+ seconds.

[teunlielu]

I think so you have Syncfashion/blazor components in you validation model. Remove them.

[fdbva]

Yes, I use their dropdowns. All I'm using from them is their dropdowns though. They were working with Blazored, that's not something new.

I guess this would be a breaking change then?

Each of the dropdowns binds to a SelectedId property on the page and an event OnSelectedChanged does some business logics, finds the correct item and assigns default values.

When I add a new Child1, there are 4 of these dropdowns. Could the issue be that I'm not binding directly to the model?

Changing these components are a bit bigger of a scope, but I'll get back here when I do and hopefully it'll be enough.

Thanks for the prompt answer.

[teunlielu]

I'm not developer. But you must check parend en child1 en 2 object wich fields they have. Property to blazor/Syncfashion will fail. Ofcourse not binding to int field. But the fully object. Check trace for failing prop. Comments field fond correct one.

[teunlielu]

Good fix is everting of ComponentBase skipping:
ComponentBase = Blazor componts;
https://learn.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.components.componentbase?view=aspnetcore-10.0
Nice solution for me too .
Checking Blazor components directly is normally not the intention and can be enormously large and deep

private static bool IsSystemType(Type type)
{
    return type.IsPrimitive ||
           type.IsValueType ||
           type.IsEnum ||
           type == typeof(string) ||
           type == typeof(Uri) ||
           type == typeof(Type) ||       
           type.IsSubclassOf(typeof(ComponentBase) || ' Add this line
           (type.IsGenericType && type.GetGenericTypeDefinition() == typeof(Nullable<>));
}

[pwelter34]

that is a good idea. I'll improve it however, to ignore anything implementing IComponent.

[pwelter34]

Should be resolved in v2.3.0. Add new support for adding your own types to ignore in path resolver. See https://github.com/loresoft/Blazilla?tab=readme-ov-file#customizing-path-resolution-type-traversal

[fdbva]

That's awesome, thanks for the prompt response.

I think so you have Syncfashion/blazor components in you validation model. Remove them.

I managed to sidestep the problem doing a few changes:

1. I completely removed the <FluentValidator /> tag, I'm injecting the IValidator and calling it only when I save, to sidestep onchange cascading searches/slowness.
2. by going to simple inputs, not Syncfusion and not mapping to properties on my component, but on my model

My EF model being a cyclical graph and having collections of collections is probably making it worse.
It feels a bit slow still, but it's much better.
My guess is that the change 1 that made the difference, but I don't have time to recreate the scenarios in isolation, unfortunately.

I haven't tried the new version yet, but by completely remaking this on my side I'm probably sidestepping the worse of this.

===

Should be resolved in v2.3.0. Add new support for adding your own types to ignore in path resolver. See https://github.com/loresoft/Blazilla?tab=readme-ov-file#customizing-path-resolution-type-traversal

I'm sorry, but I'm not sure I understand how to use it.

The problem is that many of the classes I would add on ignore for this page are needed on other registration pages for validation, so I can't do a global ignore on startup as suggested.

This is my most complex page, but it depends on several models that load with this entity and these other models are registration pages that use the Blazilla as well.

[pwelter34]

Perhaps I could add an ignore attribute to skip certain properties? Would that help?

[fdbva]

what makes sense in my head is to AddIgnoredType with context.
For example, AddIgnoredTypeFor(root: A, B, C, D).

In this case if the root model for the context is A, I will ignore B, C and D.

This isn't probably the best signature example, but just to pass the idea.

Or even when I implement the AbstractValidator<> I could have an override to set the ignored types for when that element is the root model.
Probably better than doing on Program.cs.

[fdbva]

I'm on 2.3.0, but another page that I validate on change is not working, it's completely freezing.
(It would work with blazored)

I have a _editContext.OnFieldChanged += EditContextOnOnFieldChanged; and call _editContext.Validate(); inside it, among several other logics, where I have to manually handle/change some GetValidationMessages().

I guess I should use _editContext.OnValidationStateChanged for this? I want to validate on every change and not oninput.
I've made several changes based on this idea but I'm having a hard time making it work.

For short term, at least, I'll bypass most of it, removing <FluentValidator /> and directly injecting the IValidator, similar to what I did on the other page.

[teunlielu]

@fdbva Check_editContext.OnFieldChanged += EditContextOnOnFieldChanged. Which object is sending.
Model and Fieldnam is this your object? Or Wrapper object. Last You must changed.