After #276 , invalid eth signatures are blocked from being sent as cosmos tx memo. This remove the need of manually refunding problematic cosmos tx that will fail the migration.
However, since no cosmos tx is sent, the existing migration would not fail. The user is able to retry in frontend by reconnecting to correct eth wallet, but proceeding with migration would yield a 500 error err like coin migration in progress, due to previous existing migration with problematic eth wallet is not failed/removed.
We should either
- (Hacky) Fail the exiting migration` by sending a invalid cosmos tx, if invalid eth signature is detected
- Allow frontend to proactively
end or fail a existing migration if invalid data is detected after creating a migration.
After #276 , invalid eth signatures are blocked from being sent as cosmos tx memo. This remove the need of manually refunding problematic cosmos tx that will fail the migration.
However, since no cosmos tx is sent, the existing migration would not fail. The user is able to retry in frontend by reconnecting to correct eth wallet, but proceeding with migration would yield a 500 error
err like coin migration in progress, due to previous existing migration with problematic eth wallet is not failed/removed.We should either
endorfaila existing migration if invalid data is detected after creating a migration.