Skip to content

Setup deletion confirmation describes deletion of contact information #635

Description

@exromany

Locations

Summary

The confirmation shown before deleting a setup says that filled contact information will be deleted. Both operator and delegated setup forms then execute setup deletion, so the final reviewed target contradicts the destructive effect.

Root cause

The shared setup ConfirmRemoveModal hardcodes contact-information wording and receives no setup identity, while both setup forms call their indexed remove() operation after that modal resolves successfully.

Impact

An authenticated operator or delegate can approve a permanent setup deletion after being explicitly shown confirmation for a different data category. The deleted survey can be recreated but its prior answers are lost; this is correctable non-financial state loss with no on-chain effect, so severity is low.

Scenario

  • A user opens an existing operator or delegated setup and presses Delete.
  • The modal asks whether to delete “filled contact info,” without naming the setup or index.
  • The user accepts the displayed confirmation.
  • The handler deletes the indexed setup record rather than contact information.

Drafted from LidoLens finding SURVEY-DATA-02

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions