fix: improve icon validation and diagnostics

- Validate icon exists AND is valid size (>1KB)
- Fixed DMG icon name extraction (was using old broken pattern)
- Added diagnostics to check Info.plist CFBundleIconFile
- Show actual icon files found in Resources folder

This should properly detect if IconComposer fails and use fallback

Author: libekonst

.github/workflows/build-macos.yml

@@ -55,7 +55,26 @@ jobs:
           echo "🔍 Checking for icon: ${ICON_NAME}.icns"
           echo "📁 Icon path: ${ICON_PATH}"
 
-          if [ ! -f "$ICON_PATH" ]; then
+          # Check if icon exists and is valid
+          ICON_VALID=false
+          if [ -f "$ICON_PATH" ]; then
+            echo "✅ Icon file exists"
+            ls -lh "$ICON_PATH"
+            file "$ICON_PATH"
+
+            # Verify it's a valid icns file (should be > 1KB and have correct magic bytes)
+            ICON_SIZE=$(stat -f%z "$ICON_PATH" 2>/dev/null || echo "0")
+            if [ "$ICON_SIZE" -gt 1000 ]; then
+              echo "✅ Icon size looks good: ${ICON_SIZE} bytes"
+              ICON_VALID=true
+            else
+              echo "⚠️  Icon file too small (${ICON_SIZE} bytes), treating as invalid"
+            fi
+          else
+            echo "⚠️  Icon file not found"
+          fi
+
+          if [ "$ICON_VALID" = false ]; then
             echo "⚠️  Icon not found. Building AppIcon.appiconset as fallback..."
 
             # Create output directory
@@ -96,7 +115,10 @@ jobs:
           ls -la build/Build/Products/Release/Taskito.app/Contents/Resources/
           echo ""
           echo "🎨 Looking for icon files..."
-          find build/Build/Products/Release/Taskito.app/Contents/Resources -name "*.icns" || echo "⚠️  No .icns files found!"
+          find build/Build/Products/Release/Taskito.app/Contents/Resources -name "*.icns" -exec ls -lh {} \; || echo "⚠️  No .icns files found!"
+          echo ""
+          echo "📄 Checking Info.plist for icon reference..."
+          /usr/libexec/PlistBuddy -c "Print :CFBundleIconFile" build/Build/Products/Release/Taskito.app/Contents/Info.plist || echo "⚠️  CFBundleIconFile not set"
 
       - name: Install appdmg and fileicon
         run: |
@@ -113,7 +135,7 @@ jobs:
       - name: Set DMG Icon
         run: |
           # Extract the app icon name from the project file
-          ICON_NAME=$(grep -A1 "ASSETCATALOG_COMPILER_APPICON_NAME" Taskito.xcodeproj/project.pbxproj | grep "=" | head -1 | sed 's/.*= "\(.*\)";/\1/')
+          ICON_NAME=$(grep "ASSETCATALOG_COMPILER_APPICON_NAME" Taskito.xcodeproj/project.pbxproj | head -1 | sed 's/.*= //;s/;//' | tr -d ' ')
           ICON_PATH="build/Build/Products/Release/Taskito.app/Contents/Resources/${ICON_NAME}.icns"
 
           echo "🎨 Looking for icon: ${ICON_NAME}.icns"