Skip to content

Bundled Reforged pjass.exe is very outdated #16

Description

@Luashine

Version: 2.0.2.22796

pjass.exe -v -> pjass.exe version git-f128812

Alright, it's kinda cool it leaks their internal repo's commit ID. This doesn't appear to be any of our commit IDs, so I assume they don't have pjass embedded as a git submodule (not entirely sure?), but it resides inside their monorepo. The reported version commit ID is useless to us. It's set as part of the makefile script.

Do we care to include a "static" version identifier in addition to commit ID? To have a repository agnostic way to figure out what version is running... what version Reforged is running? Though in this case they may never update their copy-pasted version anyway.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions