Since version 1.13.0.0, RouteViewer has issues with FormCLCR and RoofCLCR.

[ginga81]

Description

When extract and loading 1157M.csv from BVE4's Uchibo10.zip, only RouteViewer displays FormCL and CR, and RoofCL and CR, as shown in the screenshot.
OpenBVE displays them correctly.

Reproduction

Route

1157M.csv from BVE4's Uchibo10.zip

Train

RouteViewer isn't load train.

Logs

This issue isn't crash. So no log.

Related information

OS:Ubuntu 24.04 LTS 64bit
CPU:24 × AMD Ryzen 9 9900X 12-Core Processor
Memory:30.5 GiB single channel
Graphic: Radeon RX 9060 XT 16GB

[adfriz]

i have somewhat fix the issue locally... but im still unsure is the fix going to fix this issue only and may broke something that im not aware of...

anyway left is the fix, right is route viewer in 1.13.0.2

There is difference in total errors.

in 1.13.0.2 it shows 18 errors:

Information		INFO: Using the Japanese compatibility signal set.
Error		DaytimeTimetable 0 with FileName 1157M.bmp was not found in TimetableDay at line 10, column 1 in file 1157M.csv
Error		FileName PCheck.bmp not found in Track.Marker at line 307, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 345, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 428, column 1 in file 1157M.csv
Error		RailIndex 5 does not reference an existing dike in Track.DikeEnd at line 1116, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1493, column 1 in file 1157M.csv
Warning		RailIndex1 6 could be out of range in Track.Crack at line 1529, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1560, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1622, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1702, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1741, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1788, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1870, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1886, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 2008, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 2087, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 2178, column 1 in file 1157M.csv

in the fix it shows 89:

Information		INFO: Using the Japanese compatibility signal set.
Error		DaytimeTimetable 0 with FileName 1157M.bmp was not found in TimetableDay at line 10, column 1 in file 1157M.csv
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\glow30.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\glow32.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\glow34.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\glow4yg0.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\glow4yg2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\glow4yg3.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\glow4yg4.bmp
Error		FileName PCheck.bmp not found in Track.Marker at line 307, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 345, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 428, column 1 in file 1157M.csv
Error		RailIndex 5 does not reference an existing dike in Track.DikeEnd at line 1116, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1493, column 1 in file 1157M.csv
Warning		RailIndex1 6 could be out of range in Track.Crack at line 1529, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1560, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1622, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1702, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1741, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1788, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1870, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 1886, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 2008, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 2087, column 1 in file 1157M.csv
Error		BeaconStructureIndex 5 references an object not loaded in Track.Beacon at line 2178, column 1 in file 1157M.csv
Error		InvalidData : Invalid compressed image size in Bitmap file Grass.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Tie.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Ballast.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Rail2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file pole_c.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file pole_s.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Form2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file FormSide.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file FormC.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Stop6.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Slab2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Stop8.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file p0.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file e231s.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file E231S2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Stop15.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file p1.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Rail.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Sw_B.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Sw.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Sw_F.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file tes.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file checkP.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file swRadio.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Signal3.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file LimS40L.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file tie_w.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file call1.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\signal34.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\repeat4.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\signal4yg4.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Bg_Fine.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Grass.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Rail2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Ballast.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Tie.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file FormSide.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Form2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file FormC.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Stop6.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Slab2.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Stop8.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file p0.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file e231s.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Stop15.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file p1.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Ballast.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Sw_F.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Sw.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Sw_B.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Rail.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Ballast.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file tes.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file checkP.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file swRadio.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file LimS40L.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Rail.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file tie_w.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file pole_c.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file pole_s.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file call1.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file sigs\signal34.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file Signal3.bmp
Error		InvalidData : Invalid compressed image size in Bitmap file E231S2.bmp

@leezer3 if you have time, please check.

[leezer3]

Ignore the BMP errors.
They're harmless and only show in debug mode. Probably ought to remove them.

[leezer3]

Looks like the improvements to vertex de-duplication shifted the indicies in some cases, which breaks the old algorithm totally.
Your fix seems OK to me, although I'm sure there must have been a reason for the > 0.1 check.

Will merge for the minute.

[adfriz]

Looks like the improvements to vertex de-duplication shifted the indicies in some cases, which breaks the old algorithm totally.
Your fix seems OK to me, although I'm sure there must have been a reason for the > 0.1 check.

maybe it was a typo? the comment was said "If vertical, or both distances are within 0.1m use scale instead" but it was wrote > 0.1 not < 0.1 .

if i check the git history, commit 9de2d6d has commit message about PutBetween transform, bve2 or 4 related maybe?

[ginga81]

I think that this was fixed in version 1.13.0.3.
I think it's okay to close this, but what do you think?

[leezer3]

#1326

Not quite there yet. Not looked into that at the minute, but it's on my list...

[ginga81]

There have been reports that in version 1.13.0.5, the display of the Uchibo Line was distorted in both RouteViewer and OpenBVE, as shown in the screenshot. I experienced the same symptoms on my Ubuntu 24.04 system, so I've attached a screenshot.

[adfriz]

i think i have fixed it... but i feel my fix changing the code algorithm too much...

PR #1334

@leezer3 you may want to take a look

[ginga81]

https://github.com//pull/1334#event-26744958635 By this, I think it has been recovered.