Commit 7ca2f5d
committed
Keep empty signing secrets out of release builds
The v0.3.2 release proved that exporting blank CSC_LINK makes electron-builder treat the macOS project directory as a certificate path. The workflow now only exports CSC_LINK when the certificate secret is present and otherwise unsets signing variables before packaging.
Constraint: GitHub Actions exposes absent secrets as empty environment values when mapped directly
Rejected: Re-run v0.3.2 unchanged | release workflow fails before artifacts are uploaded
Confidence: high
Scope-risk: narrow
Directive: Do not expose blank CSC_LINK/CSC_KEY_PASSWORD to electron-builder; unset them when unsigned builds are intentional
Tested: node --test apps/macos/electron/*.test.cjs; npm run typecheck; ruby YAML parse for release.yml; git diff --check; unset CSC_LINK CSC_KEY_PASSWORD with CSC_IDENTITY_AUTO_DISCOVERY=false npm --workspace @paste/macos run dist -- --mac zip --arm64
Not-tested: Production Developer ID certificate signing path in GitHub Actions1 parent 2adf2d9 commit 7ca2f5d
4 files changed
Lines changed: 23 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
| 19 | + | |
22 | 20 | | |
23 | 21 | | |
24 | 22 | | |
| |||
55 | 53 | | |
56 | 54 | | |
57 | 55 | | |
58 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
59 | 72 | | |
60 | 73 | | |
61 | 74 | | |
62 | 75 | | |
63 | | - | |
| 76 | + | |
64 | 77 | | |
65 | 78 | | |
66 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
0 commit comments