From 6683ec788f3fb2b6c06e10856ff19a8cfbd23e1b Mon Sep 17 00:00:00 2001 From: Paolo Tramonti Date: Wed, 18 Jul 2018 12:00:49 +0200 Subject: [PATCH 1/2] New feature to add a comment on all slots when adding more slots. --- mailtemplatelib.php | 1 + slotforms.php | 5 +++++ teacherview.controller.php | 4 ++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/mailtemplatelib.php b/mailtemplatelib.php index 51400c97..28d63a28 100644 --- a/mailtemplatelib.php +++ b/mailtemplatelib.php @@ -166,6 +166,7 @@ public static function get_scheduler_variables(scheduler_instance $scheduler, $ $vars ['TIME'] = userdate($slot->starttime, get_string('strftimetime'), $tz); $vars ['ENDTIME'] = userdate($slot->endtime, get_string('strftimetime'), $tz); $vars ['LOCATION'] = format_string($slot->appointmentlocation); + $vars ['NOTES'] = format_string($slot->notes); } if ($teacher) { $vars['ATTENDANT'] = fullname($teacher); diff --git a/slotforms.php b/slotforms.php index db9b9b9f..410ae4c7 100644 --- a/slotforms.php +++ b/slotforms.php @@ -577,6 +577,11 @@ protected function definition() { $mform->addElement('select', 'emaildaterel', get_string('emailreminder', 'scheduler'), $remindersel); $mform->setDefault('remindersel', -1); + + // Slot comments. + $mform->addElement('editor', 'notes', get_string('comments', 'scheduler'), + array('rows' => 3, 'columns' => 60), $this->noteoptions); + $mform->setType('notes', PARAM_RAW); // Must be PARAM_RAW for rich text editor content. $this->add_action_buttons(); diff --git a/teacherview.controller.php b/teacherview.controller.php index a477615f..8240d993 100644 --- a/teacherview.controller.php +++ b/teacherview.controller.php @@ -42,8 +42,8 @@ function scheduler_action_doaddsession($scheduler, $formdata) { } else { $slot->duration = $data->endhour * 60 + $data->endminute - $data->starthour * 60 - $data->startminute; }; - $slot->notes = ''; - $slot->notesformat = FORMAT_HTML; + $slot->notes = $data->notes['text']; + $slot->notesformat = $data->notes['format']; $slot->timemodified = time(); for ($d = 0; $d <= $fordays; $d ++) { From d9503f0be7fa2cfd15685d091353ae92570093b7 Mon Sep 17 00:00:00 2001 From: Paolo Tramonti Date: Wed, 18 Jul 2018 12:10:24 +0200 Subject: [PATCH 2/2] Fix indentation of the code. --- mailtemplatelib.php | 2 +- slotforms.php | 2 +- teacherview.controller.php | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mailtemplatelib.php b/mailtemplatelib.php index 28d63a28..2af9aa3d 100644 --- a/mailtemplatelib.php +++ b/mailtemplatelib.php @@ -166,7 +166,7 @@ public static function get_scheduler_variables(scheduler_instance $scheduler, $ $vars ['TIME'] = userdate($slot->starttime, get_string('strftimetime'), $tz); $vars ['ENDTIME'] = userdate($slot->endtime, get_string('strftimetime'), $tz); $vars ['LOCATION'] = format_string($slot->appointmentlocation); - $vars ['NOTES'] = format_string($slot->notes); + $vars ['NOTES'] = format_string($slot->notes); } if ($teacher) { $vars['ATTENDANT'] = fullname($teacher); diff --git a/slotforms.php b/slotforms.php index 410ae4c7..ffb46695 100644 --- a/slotforms.php +++ b/slotforms.php @@ -578,7 +578,7 @@ protected function definition() { $mform->addElement('select', 'emaildaterel', get_string('emailreminder', 'scheduler'), $remindersel); $mform->setDefault('remindersel', -1); - // Slot comments. + // Slot comments. $mform->addElement('editor', 'notes', get_string('comments', 'scheduler'), array('rows' => 3, 'columns' => 60), $this->noteoptions); $mform->setType('notes', PARAM_RAW); // Must be PARAM_RAW for rich text editor content. diff --git a/teacherview.controller.php b/teacherview.controller.php index 8240d993..34cb3021 100644 --- a/teacherview.controller.php +++ b/teacherview.controller.php @@ -42,8 +42,8 @@ function scheduler_action_doaddsession($scheduler, $formdata) { } else { $slot->duration = $data->endhour * 60 + $data->endminute - $data->starthour * 60 - $data->startminute; }; - $slot->notes = $data->notes['text']; - $slot->notesformat = $data->notes['format']; + $slot->notes = $data->notes['text']; + $slot->notesformat = $data->notes['format']; $slot->timemodified = time(); for ($d = 0; $d <= $fordays; $d ++) {