From 134f205bdde26409927856e07cadff6e467dff9d Mon Sep 17 00:00:00 2001
From: David Thrane Christiansen <david@davidchristiansen.dk>
Date: Thu, 14 Aug 2025 09:36:39 +0200
Subject: [PATCH] chore: give a more pleasant error when no remote config
 exists

---
 src/multi-verso/MultiVerso.lean | 37 ++++++++++++++++++++++-----------
 1 file changed, 25 insertions(+), 12 deletions(-)

diff --git a/src/multi-verso/MultiVerso.lean b/src/multi-verso/MultiVerso.lean
index 4b5ea89ae..d3844ac96 100644
--- a/src/multi-verso/MultiVerso.lean
+++ b/src/multi-verso/MultiVerso.lean
@@ -311,15 +311,24 @@ private def fetchFile (project : System.FilePath) (root : String) (file : System
   let json ← Json.parse json |> IO.ofExcept
   fromXrefJson root json |> IO.ofExcept
 
+private def defaultConfigFile (project : System.FilePath) : System.FilePath := project / "verso-sources.json"
+
+/--
+Returns `true` if the user has specified a configuration file, or if they haven't and the default file exists.
+-/
+private def hasConfig (project : System.FilePath) (configFile : Option System.FilePath) : IO Bool := do
+  if configFile.isSome then return true
+  else defaultConfigFile project |>.pathExists
+
 private def getConfig (project : System.FilePath) (configFile : Option System.FilePath) : IO Config := do
-    let configFile : System.FilePath :=
-      if let some f := configFile then f
-      else project / "verso-sources.json"
-    let configJson ← IO.FS.readFile configFile
-    let configJson ← Json.parse configJson |> IO.ofExcept
-    match Config.fromJson? configJson with
-    | .error e => throw <| IO.userError s!"Error reading {configFile}: {e}"
-    | .ok v => pure v
+  let configFile : System.FilePath :=
+    if let some f := configFile then f
+    else defaultConfigFile project
+  let configJson ← IO.FS.readFile configFile
+  let configJson ← Json.parse configJson |> IO.ofExcept
+  match Config.fromJson? configJson with
+  | .error e => throw <| IO.userError s!"Error reading {configFile}: {e}"
+  | .ok v => pure v
 
 /--
 Information about a remote document
@@ -411,10 +420,14 @@ def updateRemotes (manual : Bool) (configFile : Option System.FilePath) (logVerb
   if let some f := configFile then
     logVerbose s!"Config override is {f}."
   let config ←
-    try
-      getConfig project configFile
-    catch e =>
-      logVerbose s!"Didn't load remote data config. No remote data to be used. Error: {e}"
+    if (← hasConfig project configFile) then
+      try
+        getConfig project configFile
+      catch e =>
+        logVerbose s!"Didn't load remote data config. No remote data to be used. Error: {e}"
+        return {}
+    else
+      logVerbose s!"No remote data configuration specified, and the default file {defaultConfigFile "."} does not exist."
       return {}
 
   logVerbose s!"Creating remote data cache directory {config.outputDir}"