Merge ab93b8a into 5594178

Author: sankalpsthakur

src/Lean/Shell.lean

@@ -301,6 +301,8 @@ def ShellOptions.process (opts : ShellOptions)
     let arg ← checkOptArg "j" optArg?
     let some numThreads := arg.toNat?
       | throwExpectedNumeric "j"
+    if numThreads == 0 then
+      throwExpectedPositive "j"
     if h : numThreads < UInt32.size then
       let numThreads := UInt32.ofNatLT numThreads h
       let forwardedArgs := opts.forwardedArgs.push s!"-j{arg}";
@@ -460,6 +462,9 @@ where
   @[inline] throwExpectedNumeric opt := do
     eprint s!"error: expected numeric argument for option '-{opt}'\n"
     throw 1
+  @[inline] throwExpectedPositive opt := do
+    eprint s!"error: expected positive numeric argument for option '-{opt}'\n"
+    throw 1
   @[inline] throwTooLarge opt := do
     eprint s!"error: argument value for '-{opt}' is too large\n"
     throw 1

tests/misc/threads_zero.sh

@@ -0,0 +1,11 @@
+set -euo pipefail
+
+out="${NAME}.out"
+trap 'rm -f "$out"' EXIT
+
+if lean -j0 >"$out" 2>&1; then
+  echo "lean -j0 unexpectedly succeeded" >&2
+  exit 1
+fi
+
+grep -Fx "error: expected positive numeric argument for option '-j'" "$out"