Skip to content
This repository was archived by the owner on Jun 10, 2026. It is now read-only.
This repository was archived by the owner on Jun 10, 2026. It is now read-only.

WHIR proof is not bound to the caller-supplied statement #2

Description

@Cameudis

In the current implementation, prove() and verify() treat the caller-supplied statement as an external parameter rather than authenticated proof input.
The prover samples the initial combination challenge gamma from the transcript before observing the statement:

statement.splice(0..0, ood_statements);

The verifier derives the same gamma from the proof transcript alone, without ever authenticating the statement:
// Combine OODS and statement constraints to claimed_sum
let constraints: Vec<_> = prev_commitment
.oods_constraints()
.into_iter()
.chain(statement)
.collect();
let combination_randomness =
self.combine_constraints(verifier_state, &mut claimed_sum, &constraints)?;
round_constraints.push((combination_randomness, constraints));

As a result, a valid proof is not cryptographically tied to the statement it is supposed to attest to.
On top of that, combine_constraints() reduces all claims to a single random linear combination and the final check validates only that aggregate:
pub(crate) fn combine_constraints(
&self,
verifier_state: &mut impl FSVerifier<EF>,
claimed_sum: &mut EF,
constraints: &[SparseStatement<EF>],
) -> ProofResult<Vec<EF>> {
let combination_randomness_gen: EF = verifier_state.sample();
let mut combination_randomness = vec![EF::ONE];
for smt in constraints {
for e in &smt.values {
let combination_randomness_pow = *combination_randomness.last().unwrap();
*claimed_sum += combination_randomness_pow * e.value;
combination_randomness
.push(combination_randomness_pow * combination_randomness_gen);
}
}
combination_randomness.pop().unwrap();
Ok(combination_randomness)
}

let evaluation_of_weights =
self.eval_constraints_poly(&round_constraints, folding_randomness.clone());

This means extra claims with false values can be appended as long as they cancel each other under the combination, and the verifier still returns Ok. Concretely, a valid proof for an honest statement can be replayed against a forged statement — including injected false claims — and verification succeeds unchanged.

Suggested fix

Serialize and absorb the full statement into the Fiat-Shamir transcript before combination_randomness_gen is sampled, on both prover and verifier sides. Also add negative tests asserting that replaying a proof against a modified statement always returns Err(ProofError::InvalidProof).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions